Page MenuHomePhabricator

[libunwind] [cmake] Support overriding LLVM_CMAKE_PATH
AbandonedPublic

Authored by mgorny on Jan 4 2017, 8:07 AM.

Details

Summary

Make LLVM_CMAKE_PATH a cache variable in order to support user
overrides. This is useful when building multiple multilib variants of
libunwind using CMake files from a single-ABI install of LLVM, e.g. when
LLVM_LIBDIR_SUFFIX == "32" but CMake files are to be found in
/usr/lib64/cmake/llvm. Since libunwind is not using any of the LLVM
build configuration variables (just generic macros), it is fine to use
CMake files from a different ABI.

Diff Detail

Event Timeline

mgorny updated this revision to Diff 83058.Jan 4 2017, 8:07 AM
mgorny retitled this revision from to [libunwind] [cmake] Support overriding LLVM_CMAKE_PATH.
mgorny updated this object.
mgorny added reviewers: mclow.lists, beanz, phosek, EricWF.
mgorny added a subscriber: cfe-commits.
mgorny planned changes to this revision.Jan 6 2017, 12:30 AM

Since D26894 was accepted, I will be preparing a patch using that instead.

mgorny requested a review of this revision.Jan 7 2017, 4:12 AM

@EricWF suggests that it'd be better to wait a while before depending on newer llvm-config, so it'd probably be preferable to do this one instead first.

mgorny abandoned this revision.Jan 10 2017, 8:06 AM

And the original variant landed in after all. Sorry for the noise.