This is an archive of the discontinued LLVM Phabricator instance.

Differential D28283

[test] Remove unused 'test_examples' config var
ClosedPublic

Authored by mgorny on Jan 4 2017, 3:30 AM.

Details

Reviewers
whitequark
beanz
lhames
Commits
rG82eb45a6f882: [test] Remove unused 'test_examples' config var
rL291283: [test] Remove unused 'test_examples' config var
Summary

Remove config.test_examples from lit.site.cfg and the relevant
ENABLE_EXAMPLES definition from CMake. It is not used anywhere.

Diff Detail

Repository
rL LLVM

Event Timeline

mgorny updated this revision to Diff 83025.Jan 4 2017, 3:30 AM
mgorny retitled this revision from to [test] Remove unused 'test_examples' config var.
mgorny updated this object.
mgorny added reviewers: lhames, beanz.
mgorny added a subscriber: llvm-commits.
mgorny added a child revision: D28294: [cmake] Canonicalize CMake booleans to 0/1 for Python interop.Jan 4 2017, 7:47 AM
mgorny added a reviewer: whitequark.Jan 6 2017, 12:28 AM
Closed by commit rL291283: [test] Remove unused 'test_examples' config var (authored by mgorny). · Explain WhyJan 6 2017, 1:44 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
llvm/
trunk/
test/
4 lines
1 line

Diff 83416

llvm/trunk/test/CMakeLists.txt

if(LLVM_BUILD_EXAMPLES)
set(ENABLE_EXAMPLES 1)
endif()
configure_lit_site_cfg( configure_lit_site_cfg(
${CMAKE_CURRENT_SOURCE_DIR}/lit.site.cfg.in ${CMAKE_CURRENT_SOURCE_DIR}/lit.site.cfg.in
${CMAKE_CURRENT_BINARY_DIR}/lit.site.cfg ${CMAKE_CURRENT_BINARY_DIR}/lit.site.cfg
) )
configure_lit_site_cfg( configure_lit_site_cfg(
${CMAKE_CURRENT_SOURCE_DIR}/Unit/lit.site.cfg.in ${CMAKE_CURRENT_SOURCE_DIR}/Unit/lit.site.cfg.in
${CMAKE_CURRENT_BINARY_DIR}/Unit/lit.site.cfg ${CMAKE_CURRENT_BINARY_DIR}/Unit/lit.site.cfg
) )
▲ Show 20 Lines • Show All 140 Lines • Show Last 20 Lines

llvm/trunk/test/lit.site.cfg.in

Show All 32 Lines
config.host_cxx = "@HOST_CXX@" config.host_cxx = "@HOST_CXX@"
config.host_ldflags = "@HOST_LDFLAGS@" config.host_ldflags = "@HOST_LDFLAGS@"
config.llvm_use_intel_jitevents = "@LLVM_USE_INTEL_JITEVENTS@" config.llvm_use_intel_jitevents = "@LLVM_USE_INTEL_JITEVENTS@"
config.llvm_use_sanitizer = "@LLVM_USE_SANITIZER@" config.llvm_use_sanitizer = "@LLVM_USE_SANITIZER@"
config.have_zlib = "@HAVE_LIBZ@" config.have_zlib = "@HAVE_LIBZ@"
config.have_libxar = "@HAVE_LIBXAR@" config.have_libxar = "@HAVE_LIBXAR@"
config.have_dia_sdk = @LLVM_ENABLE_DIA_SDK@ config.have_dia_sdk = @LLVM_ENABLE_DIA_SDK@
config.enable_ffi = "@LLVM_ENABLE_FFI@" config.enable_ffi = "@LLVM_ENABLE_FFI@"
config.test_examples = "@ENABLE_EXAMPLES@"
# Support substitution of the tools_dir with user parameters. This is # Support substitution of the tools_dir with user parameters. This is
# used when we can't determine the tool dir at configuration time. # used when we can't determine the tool dir at configuration time.
try: try:
config.llvm_tools_dir = config.llvm_tools_dir % lit_config.params config.llvm_tools_dir = config.llvm_tools_dir % lit_config.params
config.llvm_shlib_dir = config.llvm_shlib_dir % lit_config.params config.llvm_shlib_dir = config.llvm_shlib_dir % lit_config.params
except KeyError: except KeyError:
e = sys.exc_info()[1] e = sys.exc_info()[1]
key, = e.args key, = e.args
lit_config.fatal("unable to find %r parameter, use '--param=%s=VALUE'" % (key,key)) lit_config.fatal("unable to find %r parameter, use '--param=%s=VALUE'" % (key,key))
# Let the main config do the real work. # Let the main config do the real work.
lit_config.load_config(config, "@LLVM_SOURCE_DIR@/test/lit.cfg") lit_config.load_config(config, "@LLVM_SOURCE_DIR@/test/lit.cfg")