This is an archive of the discontinued LLVM Phabricator instance.

Correct the parent testing to avoid the special case where a DIE has a depth of 1
ClosedPublic

Authored by clayborg on Jan 3 2017, 4:14 PM.

Details

Summary

This test was testing that we could correctly find the parent of a DIE, but it was actually just testing the special case where a DIE's depth was 1. This corrects that error by adding an extra level into the the DWARF to ensure that we correctly get the parent by looking for the parent with a depth that is 1 less than the current depth.

Diff Detail

Event Timeline

clayborg updated this revision to Diff 82967.Jan 3 2017, 4:14 PM
clayborg retitled this revision from to Correct the parent testing to avoid the special case where a DIE has a depth of 1.
clayborg updated this object.
aprantl accepted this revision.Jan 3 2017, 4:17 PM
aprantl edited edge metadata.

Minor glitch, but otherwise looks fine.

unittests/DebugInfo/DWARF/DWARFDebugInfoTest.cpp
1029

This is probably a debugging leftover?

This revision is now accepted and ready to land.Jan 3 2017, 4:17 PM
This revision was automatically updated to reflect the committed changes.