[doc] Clarify steps for contributors without commit access.

[fhahn]

Summary

Update the Phabricator docs to clarify how changes are merged for contributors without commit access.

[fhahn]

@anmol It would be great if you could let me know if that change makes things clearer for new contributors.

[aaron.ballman]

docs/Phabricator.rst

131–136

somebody -> someone

132

I would drop the "usually" -- it should always be sufficient to add that comment.

[fhahn]

@aaron.ballman thanks for your comments! I've updated the patch.

[aaron.ballman]

LGTM, thank you for helping improve the documentation!

[anmol]

@fhahn thank you, this is definitely helpful to a new contributor to understand the process.

I note the wording: "...it can then be committed to trunk" and later on: "If you decide you should not commit the patch, you should explicitly abandon the review so that reviewers don’t think it is still open." So, ultimately, the contributor needs to indicate whether they wish for their patch to get committed? I would think that putting a patch on Phabricator implies that ultimately when all looks good about it, the intent is that it gets committed to trunk. On the other hand, for a reviewer with commit access, do they or do they not assume that the patch is meant to be committed? So, that needs to be clarified.

Perhaps, when the state of the review changes to: "This revision is now accepted and ready to land.", we have two questions come up for the contributor to answer:

• Do you wish for this patch to be committed to trunk?

(if so) [] Do you have commit access?

• that way, the fate of the patch does not remain ambiguous.

Also, if I may suggest:

[line 133] indicating you cannot commit the patch -> indicating that you cannot commit the patch
[line 135] recommend -> recommended

PS: I tried to add myself as a reviewer to this review, but could not figure it out. (I read: http://llvm.org/docs/Phabricator.html as well as tried to play with the controls on the top right).

[malcolm.parsons]

In D28184#632907, @anmol wrote:

PS: I tried to add myself as a reviewer to this review, but could not figure it out. (I read: http://llvm.org/docs/Phabricator.html as well as tried to play with the controls on the top right).

Change the 'action' at the bottom from 'Comment' to 'Add Reviewers' and enter your username.

[anmol]

Thank you @malcolm.parsons

docs/Phabricator.rst

 when a review changes state, for example by clicking "Accept Revision" in
 the web interface. Thus, please type LGTM into the comment box to accept
 a change from Phabricator.
 
 Committing a change
 -------------------
 
 Once a patch has been reviewed and approved on Phabricator it can then be
-committed to trunk.  There are multiple workflows to achieve this. Whichever
-method you follow it is recommend that your commit message ends with the line:
+committed to trunk. If you do not have commit access, someone has to
+commit the change for you (with attribution). It is sufficient to add
+a comment to the approved review indicating you cannot commit the patch
+yourself. If you have commit access, there are multiple workflows to commit the
+change. Whichever method you follow it is recommend that your commit message
+ends with the line:
 
 ::
 
   Differential Revision: <URL>
 
 where ``<URL>`` is the URL for the code review, starting with
 ``http://reviews.llvm.org/``.