This is an archive of the discontinued LLVM Phabricator instance.

[libcxx] [NFC] Rename _LIBCPP_TYPE_VIS_ONLY to _LIBCPP_TEMPLATE_VIS.
ClosedPublic

Authored by EricWF on Dec 29 2016, 9:57 PM.

Details

Summary

The name _LIBCPP_TYPE_VIS_ONLY is no longer accurate because both _LIBCPP_TYPE_VIS and _LIBCPP_TYPE_VIS_ONLY expand to __attribute__((__type_visibility__)) with Clang. The only remaining difference is that _LIBCPP_TYPE_VIS_ONLY can be applied to templates whereas _LIBCPP_TYPE_VIS cannot (due to dllimport/dllexport not being allowed on templates).

This patch renames _LIBCPP_TYPE_VIS_ONLY to _LIBCPP_TEMPLATE_VIS.

If there are no comments in the next day or two I'll commit this patch

Diff Detail

Event Timeline

EricWF updated this revision to Diff 82718.Dec 29 2016, 9:57 PM
EricWF retitled this revision from to [libcxx] [NFC] Rename _LIBCPP_TYPE_VIS_ONLY to _LIBCPP_TEMPLATE_VIS..
EricWF updated this object.
EricWF added reviewers: smeenai, compnerd, mclow.lists.
EricWF added a subscriber: cfe-commits.
smeenai edited edge metadata.Dec 29 2016, 9:59 PM

As you're aware, I have plans to change _LIBCPP_TYPE_VIS to expand to visibility instead of type_visibility, but I still think this rename makes sense.

As you're aware, I have plans to change _LIBCPP_TYPE_VIS to expand to visibility instead of type_visibility.

I had forgotten. Thanks for the reminder.

but I still think this rename makes sense.

Awesome, Thanks!

EricWF updated this revision to Diff 83155.Jan 4 2017, 4:00 PM
EricWF edited edge metadata.
  • Update against trunk.
EricWF accepted this revision.Jan 4 2017, 4:01 PM
EricWF added a reviewer: EricWF.

Accepting since there were no objections.

This revision is now accepted and ready to land.Jan 4 2017, 4:01 PM
EricWF closed this revision.Jan 4 2017, 4:07 PM

Committed in r291035.