This is an archive of the discontinued LLVM Phabricator instance.

Differential D28132

Fix unit test broken by D27873.
ClosedPublic

Authored by alekseyshl on Dec 27 2016, 4:49 PM.

Details

Reviewers
eugenis
Commits
rG8988ebb435e8: Fix unit test broken by D27873.
rCRT290643: Fix unit test broken by D27873.
rL290643: Fix unit test broken by D27873.
Summary

Reduce RSS size treshold in the unit test to accomodate for the smaller
ASAN quarantine size on Android (see D27873).

Diff Detail

Event Timeline

alekseyshl updated this revision to Diff 82566.Dec 27 2016, 4:49 PM
alekseyshl retitled this revision from to Fix unit test broken by D27873..
alekseyshl updated this object.
alekseyshl added a reviewer: eugenis.
alekseyshl added a subscriber: llvm-commits.
Herald added subscribers: kubamracek, danalbert. · View Herald TranscriptDec 27 2016, 4:49 PM
eugenis accepted this revision.Dec 27 2016, 5:42 PM
eugenis edited edge metadata.

LGTM
thanks!

This revision is now accepted and ready to land.Dec 27 2016, 5:42 PM
Closed by commit rL290643: Fix unit test broken by D27873. (authored by eugenis). · Explain WhyDec 27 2016, 5:52 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
test/
asan/
TestCases/
Linux/
2 lines

Diff 82566

test/asan/TestCases/Linux/quarantine_size_mb.cc

// Test quarantine_size_mb (and the deprecated quarantine_size) // Test quarantine_size_mb (and the deprecated quarantine_size)
// RUN: %clangxx_asan %s -o %t // RUN: %clangxx_asan %s -o %t
// RUN: %env_asan_opts=quarantine_size=10485760:verbosity=1:hard_rss_limit_mb=50 %run %t 2>&1 | FileCheck %s --check-prefix=Q10 // RUN: %env_asan_opts=quarantine_size=10485760:verbosity=1:hard_rss_limit_mb=50 %run %t 2>&1 | FileCheck %s --check-prefix=Q10
// RUN: %env_asan_opts=quarantine_size_mb=10:verbosity=1:hard_rss_limit_mb=50 %run %t 2>&1 | FileCheck %s --check-prefix=Q10 // RUN: %env_asan_opts=quarantine_size_mb=10:verbosity=1:hard_rss_limit_mb=50 %run %t 2>&1 | FileCheck %s --check-prefix=Q10
// RUN: %env_asan_opts=quarantine_size_mb=10:quarantine_size=20:verbosity=1 not %run %t 2>&1 | FileCheck %s --check-prefix=BOTH // RUN: %env_asan_opts=quarantine_size_mb=10:quarantine_size=20:verbosity=1 not %run %t 2>&1 | FileCheck %s --check-prefix=BOTH
// RUN: %env_asan_opts=quarantine_size_mb=1000:hard_rss_limit_mb=50 not %run %t 2>&1 | FileCheck %s --check-prefix=RSS_LIMIT // RUN: %env_asan_opts=quarantine_size_mb=1000:hard_rss_limit_mb=50 not %run %t 2>&1 | FileCheck %s --check-prefix=RSS_LIMIT
// RUN: %env_asan_opts=hard_rss_limit_mb=50 not %run %t 2>&1 | FileCheck %s --check-prefix=RSS_LIMIT // RUN: %env_asan_opts=hard_rss_limit_mb=20 not %run %t 2>&1 | FileCheck %s --check-prefix=RSS_LIMIT
#include <string.h> #include <string.h>
char *g; char *g;
static const int kNumAllocs = 1 << 11; static const int kNumAllocs = 1 << 11;
static const int kAllocSize = 1 << 20; static const int kAllocSize = 1 << 20;
int main() { int main() {
for (int i = 0; i < kNumAllocs; i++) { for (int i = 0; i < kNumAllocs; i++) {
Show All 9 Lines