This is an archive of the discontinued LLVM Phabricator instance.

Differential D28128

[asan] Fix test broken by r290540
ClosedPublic

Authored by vitalybuka on Dec 27 2016, 11:45 AM.

Details

Reviewers
myatsina
ahatanak
eugenis
Commits
rGa5a916bdcaa7: [asan] Fix test broken by r290540
rCRT290621: [asan] Fix test broken by r290540
rL290621: [asan] Fix test broken by r290540

Diff Detail

Event Timeline

vitalybuka updated this revision to Diff 82556.Dec 27 2016, 11:45 AM
vitalybuka retitled this revision from to [asan] Fix test broken by r290540.
vitalybuka updated this object.
vitalybuka added reviewers: ahatanak, eugenis, myatsina.
vitalybuka added subscribers: llvm-commits, • zizhar.
Herald added a subscriber: kubamracek. · View Herald TranscriptDec 27 2016, 11:45 AM
vitalybuka updated this revision to Diff 82557.Dec 27 2016, 11:47 AM

Updated another macro

eugenis accepted this revision.Dec 27 2016, 11:50 AM
eugenis edited edge metadata.

LGTM

This revision is now accepted and ready to land.Dec 27 2016, 11:50 AM
Closed by commit rL290621: [asan] Fix test broken by r290540 (authored by vitalybuka). · Explain WhyDec 27 2016, 11:51 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
lib/
asan/
tests/
26 lines

Diff 82557

lib/asan/tests/asan_asm_test.cc

Show First 20 Lines • Show All 51 Lines • ▼ Show 20 Lines __asm__( \
Mov " (%[ptr]), %[res] \n\t" \ Mov " (%[ptr]), %[res] \n\t" \
: [res] Reg (res) \ : [res] Reg (res) \
: [ptr] "r" (ptr) \ : [ptr] "r" (ptr) \
: "memory" \ : "memory" \
); \ ); \
return res; \ return res; \
} }
#define DECLARE_ASM_REP_MOVS(Type, Movs) \ #define DECLARE_ASM_REP_MOVS(Type, Movs) \
template <> void asm_rep_movs<Type>(Type * dst, Type * src, size_t size) { \ template <> \
void asm_rep_movs<Type>(Type * dst, Type * src, size_t size) { \
__asm__("rep " Movs " \n\t" \ __asm__("rep " Movs " \n\t" \
: "+D"(dst), "+S"(src), "+c"(size) \
: \ : \
: "D"(dst), "S"(src), "c"(size) \
: "memory"); \ : "memory"); \
} }
DECLARE_ASM_WRITE(U8, "8", "movq", "r"); DECLARE_ASM_WRITE(U8, "8", "movq", "r");
DECLARE_ASM_READ(U8, "8", "movq", "=r"); DECLARE_ASM_READ(U8, "8", "movq", "=r");
DECLARE_ASM_REP_MOVS(U8, "movsq"); DECLARE_ASM_REP_MOVS(U8, "movsq");
} // End of anonymous namespace } // End of anonymous namespace
Show All 20 Lines __asm__( \
Mov " (%[ptr]), %[res] \n\t" \ Mov " (%[ptr]), %[res] \n\t" \
: [res] Reg (res) \ : [res] Reg (res) \
: [ptr] "r" (ptr) \ : [ptr] "r" (ptr) \
: "memory" \ : "memory" \
); \ ); \
return res; \ return res; \
} }
#define DECLARE_ASM_REP_MOVS(Type, Movs) \ #define DECLARE_ASM_REP_MOVS(Type, Movs) \
template <> void asm_rep_movs<Type>(Type * dst, Type * src, size_t size) { \ template <> \
void asm_rep_movs<Type>(Type * dst, Type * src, size_t size) { \
__asm__("rep " Movs " \n\t" \ __asm__("rep " Movs " \n\t" \
: "+D"(dst), "+S"(src), "+c"(size) \
: \ : \
: "D"(dst), "S"(src), "c"(size) \
: "memory"); \ : "memory"); \
} }
} // End of anonymous namespace } // End of anonymous namespace
#endif // defined(__i386__) && defined(__SSE2__) #endif // defined(__i386__) && defined(__SSE2__)
#if defined(__x86_64__) || \ #if defined(__x86_64__) || \
(defined(__i386__) && defined(__SSE2__) && !defined(__ANDROID__)) (defined(__i386__) && defined(__SSE2__) && !defined(__ANDROID__))
▲ Show 20 Lines • Show All 156 Lines • Show Last 20 Lines