This is an archive of the discontinued LLVM Phabricator instance.

AMDGPU/EG,CM: Implement _noret global atomics
ClosedPublic

Authored by jvesely on Dec 22 2016, 2:17 PM.

Details

Summary

_ret versions will be a lot more complicated.
Passes piglits on Turks

Diff Detail

Repository
rL LLVM

Event Timeline

jvesely updated this revision to Diff 82369.Dec 22 2016, 2:17 PM
jvesely retitled this revision from to AMDGPU/EG,CM: Implement _noret global atomics.
jvesely updated this object.
jvesely added a reviewer: tstellarAMD.
jvesely set the repository for this revision to rL LLVM.
jvesely updated this revision to Diff 82372.Dec 22 2016, 2:22 PM
jvesely edited edge metadata.

Drop EG suffix

arsenm accepted this revision.Jan 16 2017, 11:52 AM
arsenm added a reviewer: arsenm.

LGTM with minor tweaks

lib/Target/AMDGPU/EvergreenInstructions.td
74–75 ↗(On Diff #82372)

Capitalize / punctuation

311–316 ↗(On Diff #82372)

Can you re-format this with the first line of the Pat after the opening <

This revision is now accepted and ready to land.Jan 16 2017, 11:52 AM
jvesely updated this revision to Diff 84586.Jan 16 2017, 1:28 PM
jvesely marked 2 inline comments as done.
This revision was automatically updated to reflect the committed changes.