Page MenuHomePhabricator

[lld] Remove unnecessary llvm/Config/config.h includes
ClosedPublic

Authored by mgorny on Dec 14 2016, 8:25 AM.

Details

Summary

Remove the includes of <llvm/Config/config.h> private LLVM header.
The relevant files seem not to use any definitions from that file,
and it is not available when building against installed LLVM.

The use in lib/ReaderWriter/MachO/MachOLinkingContext.cpp originates
from rL218718, and the use in ELF/Strings.cpp from rL274804 (where it
was moved from Symbols.cpp). In both cases, they were added as a part of
demangling support, and they provided HAVE_CXXABI_H.

Since we are now using the LLVM demangler library instead, the code was
removed and the includes and no longer necessary.

Diff Detail

Repository
rL LLVM

Event Timeline

mgorny updated this revision to Diff 81384.Dec 14 2016, 8:25 AM
mgorny retitled this revision from to [lld] Remove unnecessary llvm/Config/config.h includes.
mgorny updated this object.
mgorny added reviewers: ruiu, kledzik, pcc, beanz.
mgorny added a project: lld.
mgorny added a subscriber: llvm-commits.
ruiu accepted this revision.Dec 14 2016, 12:40 PM
ruiu edited edge metadata.

LGTM. Thanks you for doing this!

This revision is now accepted and ready to land.Dec 14 2016, 12:40 PM

Thanks for the quick review ;-).

This revision was automatically updated to reflect the committed changes.