This is an archive of the discontinued LLVM Phabricator instance.

[compiler-rt] Fix error in cmake. Check for empty list.
ClosedPublic

Authored by mpividori on Dec 13 2016, 10:23 AM.

Details

Summary

Hi,
This patch fix an error in cmake:

CMake Error at projects/compiler-rt/cmake/config-ix.cmake:420 (list):
 list sub-command REMOVE_DUPLICATES requires list to be present.

Thanks

Diff Detail

Repository
rL LLVM

Event Timeline

mpividori updated this revision to Diff 81253.Dec 13 2016, 10:23 AM
mpividori retitled this revision from to [compiler-rt] Fix error in cmake. Check for empty list..
mpividori updated this object.
mpividori added a reviewer: zturner.
mpividori set the repository for this revision to rL LLVM.
mpividori added a subscriber: llvm-commits.

@zturner I got that error again starting from scratch in a windows machine. So, I think we should add this patch.

zturner accepted this revision.Dec 14 2016, 5:15 PM
zturner edited edge metadata.
This revision is now accepted and ready to land.Dec 14 2016, 5:15 PM

Nit: Shouldn't the endif go after the message line though?

@zturner Yes, you are right.

@zturner, mmm in fact I think this is better. We can show the message if the list is empty.

This revision was automatically updated to reflect the committed changes.