It does not seem useful.
Details
Details
Diff Detail
Diff Detail
- Build Status
Buildable 2053 Build 2053: arc lint + arc unit
Event Timeline
Comment Actions
Not sure I understand the flow requiring this either. LGTM
llvm/lib/Bitcode/Reader/BitcodeReader.cpp | ||
---|---|---|
3962 | The existing IsMetadataMaterialized flag would only ever make a difference here if we already materialized some functions (which materializes any already deferred metadata and sets IsMetadataMaterialized=true). It isn't clear to me when we would encounter a module-level metadata block after materializing a function. Even if we did, removing this flag just means deferring these newly encountered blocks, then we would materialize the newly deferred metadata block once we materialize the next GV anyway. |
The existing IsMetadataMaterialized flag would only ever make a difference here if we already materialized some functions (which materializes any already deferred metadata and sets IsMetadataMaterialized=true). It isn't clear to me when we would encounter a module-level metadata block after materializing a function. Even if we did, removing this flag just means deferring these newly encountered blocks, then we would materialize the newly deferred metadata block once we materialize the next GV anyway.