Fix modernize-deprecated-headers clang-tidy warnings

[Eugene.Zelenko]

Did you enable analysis of headers in Clang-tidy?

lib/Frontend/CompilerInstance.cpp

51–52

Will be good idea to run Clang-format or sort headers manually.

lib/Lex/HeaderSearch.cpp

35

Please add empty line before using.

lib/Lex/ModuleMap.cpp

32–33

Please fix order of headers.

34

Could limits be used instead?

lib/Sema/DelayedDiagnostic.cpp

20

Please add empty line before using.

lib/Tooling/Core/QualTypeNames.cpp

16–17

Please remove empty line.

[michael.sharpe]

• Address review comments, check headers for C style headers

[michael.sharpe]

In D27655#619307, @Eugene.Zelenko wrote:

Did you enable analysis of headers in Clang-tidy?

I had not, thanks for the tip.

lib/Lex/ModuleMap.cpp

34

I built without this line on Ubuntu 16.04 without issue and I couldn't see where any limits were referenced from searching for _MAX or _MIN.

I think there might be a benefit to running include-what-you-use on this file, but I don't have the tool set up and will be without access to my personal setup for a couple weeks at the end of the year.

[Eugene.Zelenko]

Yes, IWYU is useful tool, but please note that it's not ideal, so will be good idea to check proposed changes manually.

You could build IWYU in-tree with Clang or Clang extra tools.

include/clang/Analysis/Analyses/ThreadSafetyTIL.h

 #define LLVM_CLANG_ANALYSIS_ANALYSES_THREADSAFETYTIL_H
 
 // All clang include dependencies for this file must be put in
 // ThreadSafetyUtil.h.
 #include "ThreadSafetyUtil.h"
 #include <algorithm>
 #include <cassert>
 #include <cstddef>
-#include <stdint.h>
+#include <cstdint>
 #include <utility>
 
 
 namespace clang {
 namespace threadSafety {
 namespace til {
 
 

include/clang/Basic/Linkage.h

 //===--- Linkage.h - Linkage enumeration and utilities ----------*- C++ -*-===//
 //
 //                     The LLVM Compiler Infrastructure
 //
 // This file is distributed under the University of Illinois Open Source
 // License. See LICENSE.TXT for details.
 //
 //===----------------------------------------------------------------------===//
 ///
 /// \file
 /// \brief Defines the Linkage enumeration and various utility functions.
 ///
 //===----------------------------------------------------------------------===//
 #ifndef LLVM_CLANG_BASIC_LINKAGE_H
 #define LLVM_CLANG_BASIC_LINKAGE_H
 
-#include <assert.h>
-#include <stdint.h>
 #include <utility>
 
 namespace clang {
 
 /// \brief Describes the different kinds of linkage 
 /// (C++ [basic.link], C99 6.2.2) that an entity may have.
 enum Linkage : unsigned char {
   /// \brief No linkage, which means that the entity is unique and

include/clang/Basic/TargetBuiltins.h

 /// \brief Enumerates target-specific builtins in their own namespaces within
 /// namespace ::clang.
 ///
 //===----------------------------------------------------------------------===//
 
 #ifndef LLVM_CLANG_BASIC_TARGETBUILTINS_H
 #define LLVM_CLANG_BASIC_TARGETBUILTINS_H
 
-#include <stdint.h>
 #include "clang/Basic/Builtins.h"
+#include <cstdint>
 #undef PPC
 
 namespace clang {
 
   namespace NEON {
   enum {
     LastTIBuiltin = clang::Builtin::FirstTSBuiltin - 1,
 #define BUILTIN(ID, TYPE, ATTRS) BI##ID,

lib/CodeGen/CGOpenCLRuntime.cpp

 //
 //===----------------------------------------------------------------------===//
 
 #include "CGOpenCLRuntime.h"
 #include "CodeGenFunction.h"
 #include "TargetInfo.h"
 #include "llvm/IR/DerivedTypes.h"
 #include "llvm/IR/GlobalValue.h"
-#include <assert.h>
+#include <cassert>
 
 using namespace clang;
 using namespace CodeGen;
 
 CGOpenCLRuntime::~CGOpenCLRuntime() {}
 
 void CGOpenCLRuntime::EmitWorkGroupLocalVarDecl(CodeGenFunction &CGF,
                                                 const VarDecl &D) {

lib/Driver/Types.cpp

 //===--- Types.cpp - Driver input & temporary type information ------------===//
 //
 //                     The LLVM Compiler Infrastructure
 //
 // This file is distributed under the University of Illinois Open Source
 // License. See LICENSE.TXT for details.
 //
 //===----------------------------------------------------------------------===//
 
 #include "clang/Driver/Types.h"
 #include "llvm/ADT/STLExtras.h"
 #include "llvm/ADT/StringSwitch.h"
 #include <cassert>
-#include <string.h>
+#include <cstring>
 
 using namespace clang::driver;
 using namespace clang::driver::types;
 
 struct TypeInfo {
   const char *Name;
   const char *Flags;
   const char *TempSuffix;

lib/Frontend/CodeGenOptions.cpp

 //===--- CodeGenOptions.cpp -----------------------------------------------===//
 //
 //                     The LLVM Compiler Infrastructure
 //
 // This file is distributed under the University of Illinois Open Source
 // License. See LICENSE.TXT for details.
 //
 //===----------------------------------------------------------------------===//
 
 #include "clang/Frontend/CodeGenOptions.h"
-#include <string.h>
+#include <cstring>
 
 namespace clang {
 
 CodeGenOptions::CodeGenOptions() {
 #define CODEGENOPT(Name, Bits, Default) Name = Default;
 #define ENUM_CODEGENOPT(Name, Type, Bits, Default) set##Name(Default);
 #include "clang/Frontend/CodeGenOptions.def"
 

lib/Frontend/CompilerInstance.cpp

 #include "llvm/Support/Host.h"
 #include "llvm/Support/LockFileManager.h"
 #include "llvm/Support/MemoryBuffer.h"
 #include "llvm/Support/Path.h"
 #include "llvm/Support/Program.h"
 #include "llvm/Support/Signals.h"
 #include "llvm/Support/Timer.h"
 #include "llvm/Support/raw_ostream.h"
+#include <ctime>
 #include <sys/stat.h>
 #include <system_error>
-#include <time.h>
 #include <utility>
 
 using namespace clang;
 
 CompilerInstance::CompilerInstance(
     std::shared_ptr<PCHContainerOperations> PCHContainerOps,
     bool BuildingModule)
     : ModuleLoader(BuildingModule), Invocation(new CompilerInvocation()),
       ModuleManager(nullptr),

lib/Lex/HeaderSearch.cpp

 #include "llvm/ADT/Hashing.h"
 #include "llvm/ADT/SmallString.h"
 #include "llvm/Support/Capacity.h"
 #include "llvm/Support/FileSystem.h"
 #include "llvm/Support/Path.h"
 #include <cstdio>
 #include <utility>
 #if defined(LLVM_ON_UNIX)
-#include <limits.h>
+#include <climits>
 #endif
+
 using namespace clang;
 
 const IdentifierInfo *
 HeaderFileInfo::getControllingMacro(ExternalPreprocessorSource *External) {
   if (ControllingMacro) {
     if (ControllingMacro->isOutOfDate()) {
       assert(External && "We must have an external source if we have a "
                          "controlling macro that is out of date.");
       External->updateOutOfDateIdentifier(

lib/Lex/ModuleMap.cpp

 #include "clang/Lex/Lexer.h"
 #include "clang/Lex/LiteralSupport.h"
 #include "llvm/ADT/StringRef.h"
 #include "llvm/ADT/StringSwitch.h"
 #include "llvm/Support/Allocator.h"
 #include "llvm/Support/FileSystem.h"
 #include "llvm/Support/Host.h"
 #include "llvm/Support/Path.h"
 #include "llvm/Support/raw_ostream.h"
-#include <stdlib.h>
 #if defined(LLVM_ON_UNIX)
-#include <limits.h>
+#include <climits>
 #endif
+#include <cstdlib>
 using namespace clang;
 
 Module::ExportDecl 
 ModuleMap::resolveExport(Module *Mod, 
                          const Module::UnresolvedExportDecl &Unresolved,
                          bool Complain) const {
   // We may have just a wildcard.
   if (Unresolved.Id.empty()) {

lib/Sema/DelayedDiagnostic.cpp

 // This file defines the DelayedDiagnostic class implementation, which
 // is used to record diagnostics that are being conditionally produced
 // during declarator parsing.
 //
 // This file also defines AccessedEntity.
 //
 //===----------------------------------------------------------------------===//
 #include "clang/Sema/DelayedDiagnostic.h"
-#include <string.h>
+#include <cstring>
+
 using namespace clang;
 using namespace sema;
 
 DelayedDiagnostic
 DelayedDiagnostic::makeAvailability(AvailabilityResult AR,
                                     SourceLocation Loc,
                                     const NamedDecl *D,
                                     const ObjCInterfaceDecl *UnknownObjCClass,
                                     const ObjCPropertyDecl  *ObjCProperty,

lib/Tooling/Core/QualTypeNames.cpp

 //===------- QualTypeNames.cpp - Generate Complete QualType Names ---------===//
 //
 //                     The LLVM Compiler Infrastructure
 //
 //===----------------------------------------------------------------------===//
 //
 // This file is distributed under the University of Illinois Open Source
 // License. See LICENSE.TXT for details.
 //
 //===----------------------------------------------------------------------===//
 
 #include "clang/Tooling/Core/QualTypeNames.h"
 #include "clang/AST/DeclTemplate.h"
 #include "clang/AST/DeclarationName.h"
 #include "clang/AST/GlobalDecl.h"
 #include "clang/AST/Mangle.h"
-
-#include <stdio.h>
+#include <cstdio>
 #include <memory>
 
 namespace clang {
 
 namespace TypeName {
 /// \brief Generates a QualType that can be used to name the same type
 /// if used at the end of the current translation unit. This ignores
 /// issues such as type shadowing.