[XRay][compiler-rt] Check target for XRay Flight Data Recorder

[phosek]

Summary

This target doesn't currently do anything, but it is required by the runtimes build.

[dberris]

I'm not sure what you mean here -- can you provide a bit more context? Note that we gate the adding of the unittests on whether we should build XRay and whether the target can run the unit tests. We already add the testsuite in line 31 in this same file.

Can you say something about whether the target you're building for can run the tests?

[phosek]

We're building compiler-rt runtimes using LLVM's new runtimes directory. The CMakeLists.txt for runtimes checks whether each component has a check-${component} and if not it throws an error, see: https://github.com/llvm-mirror/llvm/blob/master/runtimes/CMakeLists.txt#L118. Currently our build is broken because check-xray-fdr is missing, adding an empty target at least unbreaks the build. Alternatively, we could alter that check to e.g. to only give a warning. Adding @beanz who is the author of that check if he has some opinion.

[dberris]

Ah, okay -- that's a good enough explanation for me. :) Thanks @phosek -- I was just wondering whether that build had a bot that sent out messages yet? Or will that happen at some point later when things have been "fixed"?

[phosek]

Thanks! AFAIK there's not bot yet which would be doing the runtimes build. I'm hoping to set up a LLVM Buildbot builder for Fuchsia which is going to be using that setup, hopefully within a week or two.

test/xray/CMakeLists.txt

 set(XRAY_LIT_SOURCE_DIR ${CMAKE_CURRENT_SOURCE_DIR})
 
 set(XRAY_TESTSUITES)
+set(XRAY_FDR_TESTSUITES)
 
 set(XRAY_TEST_DEPS ${SANITIZER_COMMON_LIT_TEST_DEPS})
+set(XRAY_FDR_TEST_DEPS ${SANITIZER_COMMON_LIT_TEST_DEPS})
 
 if(NOT COMPILER_RT_STANDALONE_BUILD AND COMPILER_RT_BUILD_XRAY AND
    COMPILER_RT_HAS_XRAY)
   list(APPEND XRAY_TEST_DEPS xray)
+  list(APPEND XRAY_FDR_TEST_DEPS xray-fdr)
 endif()
 
 set(XRAY_TEST_ARCH ${XRAY_SUPPORTED_ARCH})
 if (COMPILER_RT_BUILD_XRAY AND COMPILER_RT_HAS_XRAY)
   foreach(arch ${XRAY_TEST_ARCH})
     set(XRAY_TEST_TARGET_ARCH ${arch})
     string(TOLOWER "-${arch}-${OS_NAME}" XRAY_TEST_CONFIG_SUFFIX)
     get_test_cc_for_arch(${arch} XRAY_TEST_TARGET_CC XRAY_TEST_TARGET_CFLAGS)
if(COMPILER_RT_INCLUDE_TESTS)
     list(APPEND XRAY_TESTSUITES ${CMAKE_CURRENT_BINARY_DIR}/Unit)
   endif()
 endif()
 
 add_lit_testsuite(check-xray "Running the XRay tests"
   ${XRAY_TESTSUITES}
   DEPENDS ${XRAY_TEST_DEPS})
 set_target_properties(check-xray PROPERTIES FOLDER "Compiler-RT Misc")
+
+add_lit_testsuite(check-xray-fdr "Running the XRay flight data recorder tests"
+  ${XRAY_FDR_TESTSUITES}
+  DEPENDS ${XRAY_FDR_TEST_DEPS})
+set_target_properties(check-xray-fdr PROPERTIES FOLDER "Compiler-RT Misc")