This is an archive of the discontinued LLVM Phabricator instance.

Differential D27500

[ELF] Fix the broken PPC test
ClosedPublic

Authored by phosek on Dec 6 2016, 6:57 PM.

Details

Reviewers
ruiu
davide
Commits
rG7173340e1fbb: [ELF] Fix the broken PPC test
rLLD288880: [ELF] Fix the broken PPC test
rL288880: [ELF] Fix the broken PPC test
Summary

This is related to the change in handling of entry point symbols.

Diff Detail

Repository
rL LLVM

Event Timeline

phosek updated this revision to Diff 80531.Dec 6 2016, 6:57 PM
phosek retitled this revision from to [ELF] Fix the broken PPC test.
phosek updated this object.
phosek added a reviewer: ruiu.
phosek set the repository for this revision to rL LLVM.
phosek added a project: lld.
phosek added a subscriber: llvm-commits.
Herald added a subscriber: nemanjai. · View Herald TranscriptDec 6 2016, 6:57 PM
davide accepted this revision.Dec 6 2016, 7:09 PM
davide added a reviewer: davide.
davide added a subscriber: davide.

lgtm

This revision is now accepted and ready to land.Dec 6 2016, 7:09 PM
Closed by commit rL288880: [ELF] Fix the broken PPC test (authored by phosek). · Explain WhyDec 6 2016, 7:14 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
lld/
trunk/
test/
ELF/
2 lines
3 lines

Diff 80534

lld/trunk/test/ELF/basic-ppc.s

Show All 20 Lines
// CHECK-NEXT: FileVersion: 1 // CHECK-NEXT: FileVersion: 1
// CHECK-NEXT: OS/ABI: FreeBSD (0x9) // CHECK-NEXT: OS/ABI: FreeBSD (0x9)
// CHECK-NEXT: ABIVersion: 0 // CHECK-NEXT: ABIVersion: 0
// CHECK-NEXT: Unused: (00 00 00 00 00 00 00) // CHECK-NEXT: Unused: (00 00 00 00 00 00 00)
// CHECK-NEXT: } // CHECK-NEXT: }
// CHECK-NEXT: Type: SharedObject (0x3) // CHECK-NEXT: Type: SharedObject (0x3)
// CHECK-NEXT: Machine: EM_PPC (0x14) // CHECK-NEXT: Machine: EM_PPC (0x14)
// CHECK-NEXT: Version: 1 // CHECK-NEXT: Version: 1
// CHECK-NEXT: Entry: 0x0 // CHECK-NEXT: Entry: 0x1000
// CHECK-NEXT: ProgramHeaderOffset: 0x34 // CHECK-NEXT: ProgramHeaderOffset: 0x34
// CHECK-NEXT: SectionHeaderOffset: 0x20AC // CHECK-NEXT: SectionHeaderOffset: 0x20AC
// CHECK-NEXT: Flags [ (0x0) // CHECK-NEXT: Flags [ (0x0)
// CHECK-NEXT: ] // CHECK-NEXT: ]
// CHECK-NEXT: HeaderSize: 52 // CHECK-NEXT: HeaderSize: 52
// CHECK-NEXT: ProgramHeaderEntrySize: 32 // CHECK-NEXT: ProgramHeaderEntrySize: 32
// CHECK-NEXT: ProgramHeaderCount: 7 // CHECK-NEXT: ProgramHeaderCount: 7
// CHECK-NEXT: SectionHeaderEntrySize: 40 // CHECK-NEXT: SectionHeaderEntrySize: 40
▲ Show 20 Lines • Show All 280 Lines • Show Last 20 Lines

lld/trunk/test/ELF/gc-sections-keep-shared-start.s

# RUN: llvm-mc -filetype=obj -triple=x86_64-unknown-linux %s -o %t # REQUIRES: x86
# RUN: llvm-mc -filetype=obj -triple=x86_64-unknown-linux %s -o %t
# RUN: ld.lld -shared --gc-sections -o %t1 %t # RUN: ld.lld -shared --gc-sections -o %t1 %t
# RUN: llvm-readobj --elf-output-style=GNU --file-headers --symbols %t1 # RUN: llvm-readobj --elf-output-style=GNU --file-headers --symbols %t1
# | FileCheck %s # | FileCheck %s
# CHECK: Entry point address: 0x1000 # CHECK: Entry point address: 0x1000
# CHECK: 0000000000001000 0 FUNC LOCAL HIDDEN 4 _start # CHECK: 0000000000001000 0 FUNC LOCAL HIDDEN 4 _start
# CHECK: 0000000000001006 0 FUNC LOCAL HIDDEN 4 internal # CHECK: 0000000000001006 0 FUNC LOCAL HIDDEN 4 internal
# CHECK: 0000000000001005 0 FUNC GLOBAL DEFAULT 4 foobar # CHECK: 0000000000001005 0 FUNC GLOBAL DEFAULT 4 foobar
Show All 19 Lines