This is an archive of the discontinued LLVM Phabricator instance.

[OpenMP] Remove unnecessary comment [NFC]
ClosedPublic

Authored by kkwli0 on Nov 22 2016, 3:32 PM.

Details

Summary

The comment table in CheckNestingOfRegions has grown to the size that is difficult to maintain. In addition, having such a large table (>1500 lines) in the code also affects readability. The table does not add any value to the code clarity, the remaining comments in the method is sufficient to show the intent.

Diff Detail

Repository
rL LLVM

Event Timeline

kkwli0 updated this revision to Diff 78957.Nov 22 2016, 3:32 PM
kkwli0 retitled this revision from to [OpenMP] Remove unnecessary comment [NFC}.
kkwli0 updated this object.
ABataev accepted this revision.Nov 23 2016, 11:08 AM
ABataev edited edge metadata.

LG

This revision is now accepted and ready to land.Nov 23 2016, 11:08 AM
This revision was automatically updated to reflect the committed changes.
kkwli0 retitled this revision from [OpenMP] Remove unnecessary comment [NFC} to [OpenMP] Remove unnecessary comment [NFC].Nov 23 2016, 7:31 PM
kkwli0 edited edge metadata.