This is an archive of the discontinued LLVM Phabricator instance.

Specify the dependencies of lldb-server manually
ClosedPublic

Authored by labath on Nov 22 2016, 8:36 AM.

Details

Summary

This basically just inlines the LLDBDependencies.cmake file into lldb-server
CMakeLists.txt. The reason is that most of these dependencies are not actually
necessary for lldb-server (some of them can't be removed because of
cross-dependencies, but most of the plugins can). I intend to start cleaning
these up in follow-up commits, but I want to do this first, so the subsequent
ones can be easily reverted if they don't build in some configurations.

When I cleaned these up locally, I was able to get a 30%--50% improvement in
lldb-server size.

Diff Detail

Repository
rL LLVM

Event Timeline

labath updated this revision to Diff 78880.Nov 22 2016, 8:36 AM
labath retitled this revision from to Specify the dependencies of lldb-server manually.
labath updated this object.
labath added reviewers: zturner, beanz, tfiala.
labath added a subscriber: lldb-commits.

Any thoughts on this?

tfiala accepted this revision.Nov 29 2016, 8:40 AM
tfiala edited edge metadata.

I think this is a great approach. LGTM!

This revision is now accepted and ready to land.Nov 29 2016, 8:40 AM
This revision was automatically updated to reflect the committed changes.