This is an archive of the discontinued LLVM Phabricator instance.

Differential D26974

[COFF] Add DebugInfoCodeView dependency
ClosedPublic

Authored by thegameg on Nov 22 2016, 7:48 AM.

Details

Reviewers
ruiu
grimar
Summary

rL287555 introduces a link error when building with BUILD_SHARED_LIBS:

undefined reference to llvm::codeview::CVSymbolDumper::dump(), and
more...

The functions are available in libDebugInfoCodeView, from LLVM.

Diff Detail

Event Timeline

thegameg updated this revision to Diff 78873.Nov 22 2016, 7:48 AM
thegameg retitled this revision from to [COFF] Add DebugInfoCodeView dependency.
thegameg updated this object.
thegameg added a reviewer: ruiu.
thegameg added a subscriber: llvm-commits.
Herald added a subscriber: mgorny. · View Herald TranscriptNov 22 2016, 7:48 AM
thegameg added a reviewer: grimar.Nov 23 2016, 3:40 AM
grimar edited edge metadata.Nov 23 2016, 3:43 AM

I know nothing about [COFF], sorry. Rui should be able to review.
Though looks ok for me.

thegameg added a comment.Nov 23 2016, 4:03 AM
In D26974#604057, @grimar wrote:

I know nothing about [COFF], sorry. Rui should be able to review.
Though looks ok for me.

Ok, sorry, my bad. Thanks anyway!

ruiu accepted this revision.Nov 23 2016, 8:08 AM
ruiu edited edge metadata.

LGTM. Apologies for the trouble.

This revision is now accepted and ready to land.Nov 23 2016, 8:08 AM
thegameg added a comment.Nov 23 2016, 8:11 AM
In D26974#604289, @ruiu wrote:

LGTM. Apologies for the trouble.

No problem! Can you commit this for me, please? I don't have commit access.

Thanks!

grimar closed this revision.Dec 2 2016, 11:54 PM

r287837

Revision Contents

PathSize
COFF/
1 line

Diff 78873

COFF/CMakeLists.txt

Context not available.
LINK_COMPONENTS LINK_COMPONENTS
${LLVM_TARGETS_TO_BUILD} ${LLVM_TARGETS_TO_BUILD}
Core Core
DebugInfoCodeView
DebugInfoMSF DebugInfoMSF
DebugInfoPDB DebugInfoPDB
LTO LTO
Context not available.