This is an archive of the discontinued LLVM Phabricator instance.

[docs] Add user-side for blockers/merges
AbandonedPublic

Authored by rengolin on Nov 22 2016, 4:12 AM.

Details

Diff Detail

Event Timeline

rengolin updated this revision to Diff 78850.Nov 22 2016, 4:12 AM
rengolin retitled this revision from to [docs] Add user-side for blockers/merges.
rengolin updated this object.
rengolin added reviewers: hans, tstellarAMD.
rengolin set the repository for this revision to rL LLVM.
rengolin added a subscriber: llvm-commits.
rovka added a subscriber: rovka.Nov 22 2016, 5:52 AM
rovka added inline comments.
docs/HowToReleaseLLVM.rst
267

Typo (fixed -> fixes)

docs/HowToReleaseLLVM.rst
264–266

I think anyone should be able to backport as long as the code owner approves. This saves the code owner from having to do a lot of extra work.

I also think backport requests should be a separate bugzilla entry from the initial bug report. I realize this may be inconvenient, but it makes it much easier to track.

hans edited edge metadata.Nov 28 2016, 9:59 AM

I think anyone should be able to backport as long as the code owner approves. This saves the code owner from having to do a lot of extra work.

+1

I also think backport requests should be a separate bugzilla entry from the initial bug report. I realize this may be inconvenient, but it makes it much easier to track.

I personally prefer the "reply to the commit email and cc me" approach since that includes the context of the commit, keeps the merge discussion on the same thread on the mailing list, and is low overhead. I'm not picky about this though, as long as an email is generated.

In D26963#606697, @hans wrote:

I also think backport requests should be a separate bugzilla entry from the initial bug report. I realize this may be inconvenient, but it makes it much easier to track.

I personally prefer the "reply to the commit email and cc me" approach since that includes the context of the commit, keeps the merge discussion on the same thread on the mailing list, and is low overhead. I'm not picky about this though, as long as an email is generated.

I think "reply to the commit email and cc me" works better for the x.y.0 releases, because all the commits being backported are fairly recent. For the stable releases, a lot of times people are requesting a 3+ month old commit be backported, they don't always have the commit email in their inbox any more.

However, my preference is to have policies that make the release manager's life easier, so I don't have any objections to doing the x.y.0 requests via email, but for the stable releases, I think bugzilla use should be mandatory.

rengolin updated this revision to Diff 81056.Dec 12 2016, 1:41 AM
rengolin edited edge metadata.
rengolin removed rL LLVM as the repository for this revision.

Addressing comments.

hans accepted this revision.Dec 16 2016, 8:40 AM
hans edited edge metadata.

lgtm

This revision is now accepted and ready to land.Dec 16 2016, 8:40 AM
rengolin abandoned this revision.Jul 5 2023, 5:26 AM

Hm, just found this still open. I have no idea if this ever got merged, but it's completely irrelevant now. Closing.

Herald added a project: Restricted Project. · View Herald TranscriptJul 5 2023, 5:26 AM