This is an archive of the discontinued LLVM Phabricator instance.

[ThinLTO] Implement -pass-remarks-output in ThinLTOCodeGenerator
ClosedPublic

Authored by mehdi_amini on Nov 18 2016, 11:38 PM.

Details

Summary

This will also be added to the LTO API, right now this will
bring ThinLTO on par with Monolithic LTO on Darwin.

Event Timeline

mehdi_amini retitled this revision from to [ThinLTO] Implement -pass-remarks-output in ThinLTOCodeGenerator.
mehdi_amini updated this object.
mehdi_amini added a reviewer: anemet.
mehdi_amini added subscribers: llvm-commits, tejohnson.

Teresa: there is some opportunity to improve the output to track what imported function was inlined or not. Piotr added some infrastructure, but likely not in the right format.

tejohnson accepted this revision.Nov 19 2016, 7:53 AM
tejohnson added a reviewer: tejohnson.

LGTM

Adding this to the LTO API as you mentioned would be good.

This revision is now accepted and ready to land.Nov 19 2016, 7:53 AM
This revision was automatically updated to reflect the committed changes.
anemet edited edge metadata.Nov 21 2016, 10:28 PM

Thanks, Mehdi!

davide added a subscriber: davide.Feb 10 2017, 12:42 PM
davide added inline comments.
llvm/trunk/lib/LTO/ThinLTOCodeGenerator.cpp
858–863 ↗(On Diff #78638)

I'm working on refactoring this so we can share between old and new LTO API. I noticed that if you comment out this block of code, the test still passes. Any ideas on how we can better test this?

davide added inline comments.Feb 10 2017, 1:48 PM
llvm/trunk/lib/LTO/ThinLTOCodeGenerator.cpp
858–863 ↗(On Diff #78638)

Fixed in r294784.

anemet added inline comments.Feb 10 2017, 2:25 PM
llvm/trunk/lib/LTO/ThinLTOCodeGenerator.cpp
858–863 ↗(On Diff #78638)

Thanks!