This is an archive of the discontinued LLVM Phabricator instance.

[compiler-rt] [asan] Use __SSE2__ (rather than __i686__...) for SSE2 test
ClosedPublic

Authored by mgorny on Nov 16 2016, 12:41 PM.

Details

Summary

Use the SSE2 to determine whether SSE2 is enabled in the ASAN tests
rather than relying on either of the i686 and x86_64. The former
is only set with explicit -march=i686, and therefore misses most of
the x86 CPUs that support SSE2. SSE2 is in turn defined if
the current settings (-march, -msse2) indicate that SSE2 is supported
which should be more reliable.

Diff Detail

Event Timeline

mgorny updated this revision to Diff 78245.Nov 16 2016, 12:41 PM
mgorny retitled this revision from to [compiler-rt] [asan] Use __SSE2__ (rather than __i686__...) for SSE2 test.
mgorny updated this object.
mgorny added a reviewer: kcc.
mgorny added a subscriber: cfe-commits.
kcc accepted this revision.Nov 17 2016, 8:56 AM
kcc edited edge metadata.

LGTM,
assuming you have verified that the test is still executed.

This revision is now accepted and ready to land.Nov 17 2016, 8:56 AM

I did, even twice ;-). Thanks.

This revision was automatically updated to reflect the committed changes.