Fix memory leaks (coverity issues 1365586 & 1365591)

[boris.ulasevich]

good

[malcolm.parsons]

lib/Support/APFloat.cpp

1685 ↗

(On Diff #77017)

Why not use std::unique_ptr?

[george.burgess.iv]

Thanks for working on this! Just one drive-by nit.

lib/Support/APFloat.cpp

1685 ↗

(On Diff #77017)

Piggybacking off of this, it looks like x is always deleted, so would it be correct/beneficial to use a SmallVector<integerPart, N> instead of an array that we always heap-allocate?

[sylvestre.ledru]

I will see to implement your propositions later. I wanted to address that quickly

llvm/trunk/lib/Support/APFloat.cpp

IEEEFloat::opStatus IEEEFloat::remainder(const IEEEFloat &rhs) {
   if (fs == opDivByZero)
     return fs;
 
   int parts = partCount();
   integerPart *x = new integerPart[parts];
   bool ignored;
   fs = V.convertToInteger(x, parts * integerPartWidth, true,
                           rmNearestTiesToEven, &ignored);
-  if (fs==opInvalidOp)
+  if (fs==opInvalidOp) {
+    delete[] x;
     return fs;
+  }
 
   fs = V.convertFromZeroExtendedInteger(x, parts * integerPartWidth, true,
                                         rmNearestTiesToEven);
   assert(fs==opOK);   // should always work
 
   fs = V.multiply(rhs, rmNearestTiesToEven);
   assert(fs==opOK || fs==opInexact);   // should not overflow or underflow
 
if (isFiniteNonZero() && rhs.isFiniteNonZero()) {
     if (fs == opDivByZero)
       return fs;
 
     int parts = partCount();
     integerPart *x = new integerPart[parts];
     bool ignored;
     fs = V.convertToInteger(x, parts * integerPartWidth, true,
                             rmTowardZero, &ignored);
-    if (fs==opInvalidOp)
+    if (fs==opInvalidOp) {
+      delete[] x;
       return fs;
+    }
 
     fs = V.convertFromZeroExtendedInteger(x, parts * integerPartWidth, true,
                                           rmNearestTiesToEven);
     assert(fs==opOK);   // should always work
 
     fs = V.multiply(rhs, rmNearestTiesToEven);
     assert(fs==opOK || fs==opInexact);   // should not overflow or underflow