Page MenuHomePhabricator

boris.ulasevich (Boris Ulasevich)
User

Projects

User does not belong to any projects.

User Details

User Since
Nov 3 2016, 5:28 AM (195 w, 5 d)

Recent Activity

Mar 10 2019

boris.ulasevich created D59190: [examples] Update llvm examples to new memset intrinsic API.
Mar 10 2019, 12:18 PM · Restricted Project

Mar 21 2017

boris.ulasevich added inline comments to D31182: [InstCombine] fadd double (sitofp x), y check that the promotion is valid .
Mar 21 2017, 6:58 AM

Feb 14 2017

boris.ulasevich added a comment to D29909: Break some more dependencies in lldbUtility.

FYI.
After r295088 commit Xcode project fails with "no such file or directory: '/Users/boris/ws/lldb/lldb/source/Utility/ModuleCache.cpp'" message.
I think lldb.xcodeproj/project.pbxproj should be updated.

Feb 14 2017, 11:27 PM
boris.ulasevich added a comment to D29144: LLDB: fix for TestCallThatThrows.py test fail.

Yes, it is quite old story. Original issue was that breakpoint with false condition resumes execution in spite of completed step plan. There was two local fix proposals, but finally the issue was fixed by StopInfoBreakpoint::PerformAction and Thread::GetStopInfo reworking.

Feb 14 2017, 10:55 AM
boris.ulasevich added a comment to D29144: LLDB: fix for TestCallThatThrows.py test fail.

ping!

Feb 14 2017, 1:35 AM

Feb 2 2017

boris.ulasevich added inline comments to D29394: [DAGCombiner] Support non-zero offset in load combine.
Feb 2 2017, 12:05 AM

Jan 27 2017

boris.ulasevich added a comment to D29144: LLDB: fix for TestCallThatThrows.py test fail.

What's special about the TestCallThatThrows test?

Jan 27 2017, 1:39 PM
boris.ulasevich updated the diff for D29144: LLDB: fix for TestCallThatThrows.py test fail.

I made another diff with using GetCompletedPlan call. Hope it makes the code clear.

Jan 27 2017, 11:56 AM
boris.ulasevich added a comment to D29144: LLDB: fix for TestCallThatThrows.py test fail.

When you go to pick the plan to report for the stop it should be the top of the completed plan stack, the "thread plan to call function". Why in this particular case is the bottom of the completed stack getting handed out?

Jan 27 2017, 11:54 AM

Jan 25 2017

boris.ulasevich added a comment to D29144: LLDB: fix for TestCallThatThrows.py test fail.

I work on the case when we have two plans complete: internal breakpoint plus our function call plan:

Jan 25 2017, 8:30 PM
boris.ulasevich created D29144: LLDB: fix for TestCallThatThrows.py test fail.
Jan 25 2017, 12:58 PM

Jan 23 2017

boris.ulasevich updated the diff for D28945: Add completed_plan_stack to LLDB ThreadStateCheckpoint.

description update

Jan 23 2017, 10:42 AM · Unknown Object (Project)
boris.ulasevich added a comment to D28945: Add completed_plan_stack to LLDB ThreadStateCheckpoint.

The plans should do whatever cleanup they are going to do when they get popped, and should not rely on the destructors to do this work.

Jan 23 2017, 10:40 AM · Unknown Object (Project)

Jan 20 2017

boris.ulasevich added a comment to D28945: Add completed_plan_stack to LLDB ThreadStateCheckpoint.

Jim should probably review this change.

Jan 20 2017, 10:59 AM · Unknown Object (Project)
boris.ulasevich created D28945: Add completed_plan_stack to LLDB ThreadStateCheckpoint.
Jan 20 2017, 4:32 AM · Unknown Object (Project)

Dec 19 2016

boris.ulasevich updated D26497: LLDB bug 30863: "Step" doesn't stop with conditional breakpoint on the next line.
Dec 19 2016, 11:56 PM · Unknown Object (Project)

Dec 17 2016

boris.ulasevich added inline comments to D26497: LLDB bug 30863: "Step" doesn't stop with conditional breakpoint on the next line.
Dec 17 2016, 5:08 AM · Unknown Object (Project)

Dec 15 2016

boris.ulasevich retitled D27824: BrainF example: missing output from to BrainF example: missing output.
Dec 15 2016, 12:33 PM

Dec 9 2016

boris.ulasevich updated the diff for D26497: LLDB bug 30863: "Step" doesn't stop with conditional breakpoint on the next line.

Stop reason priorities was reworked, step plans gets a last chance to mark themselves complete while cleaning up stale plans, and breakpoint's PerformAction learned to take Completed Plans into account.

Dec 9 2016, 9:24 PM · Unknown Object (Project)
boris.ulasevich added a comment to D26280: A number of issues in BrainF example.

“Doctor, doctor, everyone keeps ignoring me”. “Next please!”

Dec 9 2016, 9:00 PM

Nov 28 2016

boris.ulasevich updated the diff for D26497: LLDB bug 30863: "Step" doesn't stop with conditional breakpoint on the next line.

Here I come with another fix. Additional code in ThreadPlanStepRange::IsPlanStale() checks if we are exactly on the next instruction just after the range, and sets plan Complete in this case. So for the case we have both breakpoint hit and step plan complete event, and further processing threats step plan complete as primary event (Thread::GetStopInfo), and stop works Ok. Please note that breakpoint's actions (condition check, bump count increase, commands) are skipped when step plan is treated as main event.

Nov 28 2016, 5:39 AM · Unknown Object (Project)

Nov 24 2016

boris.ulasevich added inline comments to D26280: A number of issues in BrainF example.
Nov 24 2016, 1:19 AM

Nov 17 2016

boris.ulasevich updated D26280: A number of issues in BrainF example.
Nov 17 2016, 7:50 AM
boris.ulasevich added a comment to D26497: LLDB bug 30863: "Step" doesn't stop with conditional breakpoint on the next line.

Thank you for guiding me though this stuff. For years I was responsible for similar debugging issues in Mobile Java, and my motivation now is to learn how it works in lldb world.

Nov 17 2016, 5:04 AM · Unknown Object (Project)

Nov 16 2016

boris.ulasevich updated the diff for D26497: LLDB bug 30863: "Step" doesn't stop with conditional breakpoint on the next line.

Thank you for the review. I really appreciate it.

Nov 16 2016, 5:11 AM · Unknown Object (Project)

Nov 10 2016

boris.ulasevich added a reviewer for D26497: LLDB bug 30863: "Step" doesn't stop with conditional breakpoint on the next line: jingham.
Nov 10 2016, 7:11 AM · Unknown Object (Project)
boris.ulasevich retitled D26497: LLDB bug 30863: "Step" doesn't stop with conditional breakpoint on the next line from to LLDB bug 30863: "Step" doesn't stop with conditional breakpoint on the next line.
Nov 10 2016, 5:03 AM · Unknown Object (Project)

Nov 7 2016

boris.ulasevich added a comment to D26347: Fix memory leaks (coverity issues 1365586 & 1365591).

good

Nov 7 2016, 12:52 AM
boris.ulasevich added reviewers for D26280: A number of issues in BrainF example: rafael, Eugene.Zelenko.
Nov 7 2016, 12:10 AM

Nov 3 2016

boris.ulasevich retitled D26280: A number of issues in BrainF example from to A number of issues in BrainF example.
Nov 3 2016, 5:47 AM