Extend small data threshold driver options to PPC target

[jackoalan]

Summary

Clang-side extension of D26344

Exposes PPC target to various small data threshold arguments. Also extends alternate forms to other MIPS uses.

[jackoalan]

Rebase against latest master.

[jackoalan]

Rebase against upstream master

[rsmith]

As of r293254, the -G= and -msmall-data-threshold= flags are just aliases of -G, so you don't need those parts of this patch any more. The PPC part looks fine, but please add a testcase.

In future, please add cfe-commits as a subscriber to Clang changes; otherwise mail doesn't get sent there and patches tend to get lost.

[jackoalan]

Remove already-aliased option matchings; add test case for patch.

[rsmith]

LGTM

lib/Driver/Tools.cpp

void Clang::AddMIPSTargetArgs(const ArgList &Args,
   if (Arg *A = Args.getLastArg(options::OPT_mcheck_zero_division,
                                options::OPT_mno_check_zero_division)) {
     if (A->getOption().matches(options::OPT_mno_check_zero_division)) {
       CmdArgs.push_back("-mllvm");
       CmdArgs.push_back("-mno-check-zero-division");
     }
   }
 
-  if (Arg *A = Args.getLastArg(options::OPT_G)) {
+  if (Arg *A = Args.getLastArg(options::OPT_G, options::OPT_G_EQ,
+                               options::OPT_msmall_data_threshold_EQ)) {
     StringRef v = A->getValue();
     CmdArgs.push_back("-mllvm");
     CmdArgs.push_back(Args.MakeArgString("-mips-ssection-threshold=" + v));
     A->claim();
   }
 
   if (Arg *A = Args.getLastArg(options::OPT_mcompact_branches_EQ)) {
     StringRef Val = StringRef(A->getValue());
if (FloatABI == ppc::FloatABI::Soft) {
     CmdArgs.push_back("-mfloat-abi");
     CmdArgs.push_back("hard");
   }
 
   if (ABIName) {
     CmdArgs.push_back("-target-abi");
     CmdArgs.push_back(ABIName);
   }
+
+  if (Arg *A = Args.getLastArg(options::OPT_G, options::OPT_G_EQ,
+                               options::OPT_msmall_data_threshold_EQ)) {
+    StringRef v = A->getValue();
+    CmdArgs.push_back("-mllvm");
+    CmdArgs.push_back(Args.MakeArgString("-ppc-ssection-threshold=" + v));
+    A->claim();
+  }
 }
 
 bool ppc::hasPPCAbiArg(const ArgList &Args, const char *Value) {
   Arg *A = Args.getLastArg(options::OPT_mabi_EQ);
   return A && (A->getValue() == StringRef(Value));
 }
 
 /// Get the (LLVM) name of the R600 gpu we are targeting.
case llvm::Triple::mips64el: {
     CmdArgs.push_back(getGnuCompatibleMipsABIName(ABIName).data());
 
     if (getToolChain().getArch() == llvm::Triple::mips ||
         getToolChain().getArch() == llvm::Triple::mips64)
       CmdArgs.push_back("-EB");
     else
       CmdArgs.push_back("-EL");
 
-    if (Arg *A = Args.getLastArg(options::OPT_G)) {
+    if (Arg *A = Args.getLastArg(options::OPT_G, options::OPT_G_EQ,
+                                 options::OPT_msmall_data_threshold_EQ)) {
       StringRef v = A->getValue();
       CmdArgs.push_back(Args.MakeArgString("-G" + v));
       A->claim();
     }
 
     AddAssemblerKPIC(getToolChain(), Args, CmdArgs);
     break;
   }
if (Arch == llvm::Triple::x86) {
     CmdArgs.push_back("elf_i386_fbsd");
   }
 
   if (Arch == llvm::Triple::ppc) {
     CmdArgs.push_back("-m");
     CmdArgs.push_back("elf32ppc_fbsd");
   }
 
-  if (Arg *A = Args.getLastArg(options::OPT_G)) {
+  if (Arg *A = Args.getLastArg(options::OPT_G, options::OPT_G_EQ,
+                               options::OPT_msmall_data_threshold_EQ)) {
     if (ToolChain.getArch() == llvm::Triple::mips ||
       ToolChain.getArch() == llvm::Triple::mipsel ||
       ToolChain.getArch() == llvm::Triple::mips64 ||
       ToolChain.getArch() == llvm::Triple::mips64el) {
       StringRef v = A->getValue();
       CmdArgs.push_back(Args.MakeArgString("-G" + v));
       A->claim();
     }