Page MenuHomePhabricator

Extend small data threshold driver options to PPC target
AcceptedPublic

Authored by jackoalan on Nov 6 2016, 11:19 PM.

Details

Summary

Clang-side extension of D26344

Exposes PPC target to various small data threshold arguments. Also extends alternate forms to other MIPS uses.

Diff Detail

Event Timeline

jackoalan updated this revision to Diff 77013.Nov 6 2016, 11:19 PM
jackoalan retitled this revision from to Extend small data threshold driver options to PPC target.
jackoalan updated this object.
jackoalan set the repository for this revision to rL LLVM.
jackoalan added a reviewer: hfinkel.
jackoalan updated this revision to Diff 78314.Nov 16 2016, 7:23 PM
jackoalan removed rL LLVM as the repository for this revision.

Rebase against latest master.

jackoalan updated this revision to Diff 79809.Nov 30 2016, 1:50 PM

Rebase against upstream master

rsmith accepted this revision.Jan 26 2017, 6:20 PM
rsmith added a reviewer: cfe-commits.
rsmith added a subscriber: rsmith.

As of r293254, the -G= and -msmall-data-threshold= flags are just aliases of -G, so you don't need those parts of this patch any more. The PPC part looks fine, but please add a testcase.

In future, please add cfe-commits as a subscriber to Clang changes; otherwise mail doesn't get sent there and patches tend to get lost.

This revision is now accepted and ready to land.Jan 26 2017, 6:22 PM
jackoalan updated this revision to Diff 86088.Jan 27 2017, 11:36 AM

Remove already-aliased option matchings; add test case for patch.