This is an archive of the discontinued LLVM Phabricator instance.

llvm-strings: introduce basic strings tool
ClosedPublic

Authored by compnerd on Nov 6 2016, 7:52 PM.

Details

Summary

This is a replacement to binutils' string tool. It prints strings found in a
binary (object file, executable, or archive library). It is rather bare and
not functionally equivalent, however, it lays the groundwork necessary for the
strings tool, enabling iterative development of features to reach feature
parity.

Diff Detail

Repository
rL LLVM

Event Timeline

compnerd updated this revision to Diff 77003.Nov 6 2016, 7:52 PM
compnerd retitled this revision from to llvm-strings: introduce basic strings tool.
compnerd updated this object.
compnerd added a reviewer: mclow.lists.
compnerd set the repository for this revision to rL LLVM.
compnerd added a subscriber: echristo.
compnerd removed a subscriber: echristo.
echristo accepted this revision.Nov 10 2016, 2:27 PM
echristo edited edge metadata.

Couple of inline comments. Don't bother putting it back up for review if you just make the changes :)

-eric

tools/llvm-strings/llvm-strings.cpp
38

Lower case. Also probably worth just making this a static helper function rather than a class member for StringRef and only have class functions that take object files/archives/etc.

46

Perhaps have it take a stream instead?

This revision is now accepted and ready to land.Nov 10 2016, 2:27 PM
compnerd marked 2 inline comments as done.Nov 10 2016, 7:11 PM
compnerd closed this revision.Nov 10 2016, 8:47 PM

SVN r286556

mclow.lists edited edge metadata.Nov 10 2016, 8:56 PM

thanks for doing this!