This is an archive of the discontinued LLVM Phabricator instance.

[LLVM] Fix some Clang-tidy readability-redundant-member-init and Include What You Use warnings; other minor fixes
ClosedPublic

Authored by Eugene.Zelenko on Oct 28 2016, 10:30 AM.

Diff Detail

Repository
rL LLVM

Event Timeline

Eugene.Zelenko retitled this revision from to [LLVM] Fix some Clang-tidy readability-redundant-member-init and Include What You Use warnings; other minor fixes.
Eugene.Zelenko updated this object.
Eugene.Zelenko set the repository for this revision to rL LLVM.
Eugene.Zelenko added a subscriber: llvm-commits.

Same changes in include/llvm/CodeGen

Fix Clang-tidy modernize-use-default warnings.

mehdi_amini accepted this revision.Nov 9 2016, 10:35 AM
mehdi_amini edited edge metadata.

Thanks for the cleanup. See some suggestion inline.

include/llvm/CodeGen/LivePhysRegs.h
54

I'd change const TargetRegisterInfo *TRI = nullptr;, and this to = default;

include/llvm/Support/RWMutex.h
94

Same here: unsigned readers = 0, writers = 0; and = default;

This revision is now accepted and ready to land.Nov 9 2016, 10:35 AM
Eugene.Zelenko edited edge metadata.

Convert couple of classes to C++11 member initialization per Mehdi suggestion.

Eugene.Zelenko marked 2 inline comments as done.Nov 9 2016, 1:07 PM

We really need PR18858 implemented!

This revision was automatically updated to reflect the committed changes.