This is an archive of the discontinued LLVM Phabricator instance.

Differential D25996

[compiler-rt] Remove duplicates from COMPILER_RT_SUPPORTED_ARCH
ClosedPublic

Authored by kubamracek on Oct 26 2016, 9:46 AM.

Details

Reviewers
zaks.anna
beanz
Commits
rGc14916dae7f7: [compiler-rt] Remove duplicates from COMPILER_RT_SUPPORTED_ARCH
rCRT288681: [compiler-rt] Remove duplicates from COMPILER_RT_SUPPORTED_ARCH
rL288681: [compiler-rt] Remove duplicates from COMPILER_RT_SUPPORTED_ARCH
Summary

Since we’re adding an entry into COMPILER_RT_SUPPORTED_ARCH for all architectures of all Darwin platforms, COMPILER_RT_SUPPORTED_ARCH often ends up having duplicate items. Let’s remove them.

Diff Detail

Repository
rL LLVM

Event Timeline

kubamracek updated this revision to Diff 75909.Oct 26 2016, 9:46 AM
kubamracek retitled this revision from to [compiler-rt] Remove duplicates from COMPILER_RT_SUPPORTED_ARCH.
kubamracek updated this object.
kubamracek added a reviewer: beanz.
kubamracek added subscribers: llvm-commits, zaks.anna.
Herald added subscribers: mgorny, dberris. · View Herald TranscriptOct 26 2016, 9:46 AM
zaks.anna accepted this revision.Dec 1 2016, 10:54 PM
zaks.anna added a reviewer: zaks.anna.
This revision is now accepted and ready to land.Dec 1 2016, 10:54 PM
Closed by commit rL288681: [compiler-rt] Remove duplicates from COMPILER_RT_SUPPORTED_ARCH (authored by kuba.brecka). · Explain WhyDec 5 2016, 10:02 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
compiler-rt/
trunk/
cmake/
1 line

Diff 80286

compiler-rt/trunk/cmake/config-ix.cmake

Show First 20 Lines • Show All 418 Lines • ▼ Show 20 Lines else()
set(CAN_SYMBOLIZE 0) set(CAN_SYMBOLIZE 0)
endif() endif()
else() else()
set(CAN_SYMBOLIZE 1) set(CAN_SYMBOLIZE 1)
endif() endif()
find_program(GOLD_EXECUTABLE NAMES ${LLVM_DEFAULT_TARGET_TRIPLE}-ld.gold ld.gold ${LLVM_DEFAULT_TARGET_TRIPLE}-ld ld DOC "The gold linker") find_program(GOLD_EXECUTABLE NAMES ${LLVM_DEFAULT_TARGET_TRIPLE}-ld.gold ld.gold ${LLVM_DEFAULT_TARGET_TRIPLE}-ld ld DOC "The gold linker")
list(REMOVE_DUPLICATES COMPILER_RT_SUPPORTED_ARCH)
message(STATUS "Compiler-RT supported architectures: ${COMPILER_RT_SUPPORTED_ARCH}") message(STATUS "Compiler-RT supported architectures: ${COMPILER_RT_SUPPORTED_ARCH}")
if(ANDROID) if(ANDROID)
set(OS_NAME "Android") set(OS_NAME "Android")
else() else()
set(OS_NAME "${CMAKE_SYSTEM_NAME}") set(OS_NAME "${CMAKE_SYSTEM_NAME}")
endif() endif()
▲ Show 20 Lines • Show All 109 Lines • Show Last 20 Lines