This is an archive of the discontinued LLVM Phabricator instance.

Differential D25843

[ELF] Add DebugInfoDWARF dependency
ClosedPublic

Authored by thegameg on Oct 20 2016, 1:45 PM.

Details

Reviewers
ruiu
• rafael
grimar
Commits
rG032fa65606e2: [ELF] Add DebugInfoDWARF dependency
rLLD284810: [ELF] Add DebugInfoDWARF dependency
rL284810: [ELF] Add DebugInfoDWARF dependency
Summary

rL284708 introduces a link error when building with BUILD_SHARED_LIBS:

undefined reference to `llvm::DWARFContext::parseCompileUnits()'
undefined reference to `llvm::DWARFContextInMemory::DWARFContextInMemory(
                            llvm::object::ObjectFile const&,
                            llvm::LoadedObjectInfo const*)'

The functions are available in libDebugInfoDWARF, from llvm.

Diff Detail

Repository
rL LLVM

Event Timeline

thegameg updated this revision to Diff 75349.Oct 20 2016, 1:45 PM
thegameg retitled this revision from to [ELF] Add DebugInfoDWARF dependency.
thegameg updated this object.
thegameg added reviewers: grimar, • rafael.
thegameg added a subscriber: llvm-commits.
Herald added subscribers: mgorny, beanz. · View Herald TranscriptOct 20 2016, 1:45 PM
thegameg updated this object.Oct 20 2016, 1:46 PM
ruiu accepted this revision.Oct 20 2016, 1:51 PM
ruiu added a reviewer: ruiu.
ruiu added a subscriber: ruiu.

LGTM

This revision is now accepted and ready to land.Oct 20 2016, 1:51 PM
thegameg added a comment.Oct 20 2016, 1:57 PM

Thanks @ruiu. Can you commit this for me? I don't have commit access.

Closed by commit rL284810: [ELF] Add DebugInfoDWARF dependency (authored by grimar). · Explain WhyOct 21 2016, 12:55 AM
This revision was automatically updated to reflect the committed changes.
grimar edited edge metadata.Oct 21 2016, 12:56 AM

r284810, thanks !

Revision Contents

PathSize
lld/
trunk/
ELF/
1 line

Diff 75397

lld/trunk/ELF/CMakeLists.txt

Show All 28 Linesadd_lld_library(lldELF
LINK_COMPONENTS LINK_COMPONENTS
${LLVM_TARGETS_TO_BUILD} ${LLVM_TARGETS_TO_BUILD}
Analysis Analysis
BitReader BitReader
BitWriter BitWriter
Codegen Codegen
Core Core
DebugInfoDWARF
Demangle Demangle
IPO IPO
Linker Linker
LTO LTO
Object Object
Option Option
Passes Passes
MC MC
Show All 11 Lines