This is an archive of the discontinued LLVM Phabricator instance.

[clang] Limit clang test to ARM and AArch64 only
ClosedPublic

Authored by mgrang on Oct 20 2016, 1:21 PM.

Download Raw Diff

Details

Reviewers

rengolin
abdulras
honggyu.kim

Commits

rG66215e97e36c: [clang] Limit clang test to ARM and AArch64 only
rC284931: [clang] Limit clang test to ARM and AArch64 only
rL284931: [clang] Limit clang test to ARM and AArch64 only

Summary

Limit clang/test/Frontend/gnu-mcount.c to ARM and AArch64 only.

Diff Detail

Event Timeline

mgrang updated this revision to Diff 75344.Oct 20 2016, 1:21 PM

mgrang retitled this revision from to [clang] Limit clang test to ARM only.

mgrang updated this object.

mgrang added reviewers: abdulras, honggyu.kim.

mgrang added a project: Restricted Project.

mgrang added a subscriber: cfe-commits.

Herald added subscribers: rengolin, aemerson. · View Herald TranscriptOct 20 2016, 1:21 PM

rengolin added inline comments.Oct 20 2016, 1:30 PM

test/Frontend/gnu-mcount.c
1	If you have ARM but not AArch64, this test will also fail. Can you use AND on REQUIRES?

Test limited only to ARM and AArch64.

mgrang marked an inline comment as done.Oct 20 2016, 4:51 PM

I haven't tested with ARM and not AArch64 or vice-versa. I'm assuming you have. If so, LGTM. Thanks.

This revision is now accepted and ready to land.Oct 22 2016, 1:08 PM

Closed by commit rL284931: [clang] Limit clang test to ARM and AArch64 only (authored by mgrang). · Explain WhyOct 22 2016, 6:02 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents

Path

Size

test/

Frontend/

gnu-mcount.c

2 lines

Diff 75344

test/Frontend/gnu-mcount.c

				// REQUIRES: arm-registered-target
				rengolinUnsubmitted Done Reply Inline Actions If you have ARM but not AArch64, this test will also fail. Can you use AND on REQUIRES? rengolin: If you have ARM but not AArch64, this test will also fail. Can you use AND on REQUIRES?

	// RUN: %clang -target armv7-unknown-none-eabi -pg -S -emit-llvm -o - %s \| FileCheck %s -check-prefix CHECK -check-prefix CHECK-ARM-EABI			// RUN: %clang -target armv7-unknown-none-eabi -pg -S -emit-llvm -o - %s \| FileCheck %s -check-prefix CHECK -check-prefix CHECK-ARM-EABI
	// RUN: %clang -target armv7-unknown-none-eabi -pg -meabi gnu -S -emit-llvm -o - %s \| FileCheck %s -check-prefix CHECK -check-prefix CHECK-ARM-EABI-MEABI-GNU			// RUN: %clang -target armv7-unknown-none-eabi -pg -meabi gnu -S -emit-llvm -o - %s \| FileCheck %s -check-prefix CHECK -check-prefix CHECK-ARM-EABI-MEABI-GNU
	// RUN: %clang -target aarch64-unknown-none-eabi -pg -S -emit-llvm -o - %s \| FileCheck %s -check-prefix CHECK -check-prefix CHECK-ARM64-EABI			// RUN: %clang -target aarch64-unknown-none-eabi -pg -S -emit-llvm -o - %s \| FileCheck %s -check-prefix CHECK -check-prefix CHECK-ARM64-EABI
	// RUN: %clang -target aarch64-unknown-none-eabi -pg -meabi gnu -S -emit-llvm -o - %s \| FileCheck %s -check-prefix CHECK -check-prefix CHECK-ARM64-EABI-MEABI-GNU			// RUN: %clang -target aarch64-unknown-none-eabi -pg -meabi gnu -S -emit-llvm -o - %s \| FileCheck %s -check-prefix CHECK -check-prefix CHECK-ARM64-EABI-MEABI-GNU
	// RUN: %clang -target armv7-unknown-linux-gnueabi -pg -S -emit-llvm -o - %s \| FileCheck %s -check-prefix CHECK -check-prefix CHECK-ARM-EABI			// RUN: %clang -target armv7-unknown-linux-gnueabi -pg -S -emit-llvm -o - %s \| FileCheck %s -check-prefix CHECK -check-prefix CHECK-ARM-EABI
	// RUN: %clang -target armv7-unknown-linux-gnueabi -meabi gnu -pg -S -emit-llvm -o - %s \| FileCheck %s -check-prefix CHECK -check-prefix CHECK-ARM-EABI-MEABI-GNU			// RUN: %clang -target armv7-unknown-linux-gnueabi -meabi gnu -pg -S -emit-llvm -o - %s \| FileCheck %s -check-prefix CHECK -check-prefix CHECK-ARM-EABI-MEABI-GNU
	// RUN: %clang -target aarch64-unknown-linux-gnueabi -pg -S -emit-llvm -o - %s \| FileCheck %s -check-prefix CHECK -check-prefix CHECK-ARM64-EABI			// RUN: %clang -target aarch64-unknown-linux-gnueabi -pg -S -emit-llvm -o - %s \| FileCheck %s -check-prefix CHECK -check-prefix CHECK-ARM64-EABI
	// RUN: %clang -target aarch64-unknown-linux-gnueabi -meabi gnu -pg -S -emit-llvm -o - %s \| FileCheck %s -check-prefix CHECK -check-prefix CHECK-ARM64-EABI-MEABI-GNU			// RUN: %clang -target aarch64-unknown-linux-gnueabi -meabi gnu -pg -S -emit-llvm -o - %s \| FileCheck %s -check-prefix CHECK -check-prefix CHECK-ARM64-EABI-MEABI-GNU
	▲ Show 20 Lines • Show All 70 Lines • Show Last 20 Lines