This is an archive of the discontinued LLVM Phabricator instance.

Differential D25479

Guard flag –fdenormal-fp-math with –fno-fast-math
ClosedPublic

Authored by SjoerdMeijer on Oct 11 2016, 8:58 AM.

Details

Reviewers
rengolin
jmolloy
hfinkel
Commits
rGee3c7e0d429c: Guard flag –fdenormal-fp-math with –fno-fast-math. This allows disabling the FP…
rC284121: Guard flag –fdenormal-fp-math with –fno-fast-math.
rL284121: Guard flag –fdenormal-fp-math with –fno-fast-math.
Summary

Guard flag -fdenormal-fp-math with -fno-fast-math. This allows disabling the FP options with just one flag: –fno-fast-math.

Diff Detail

Event Timeline

SjoerdMeijer updated this revision to Diff 74264.Oct 11 2016, 8:58 AM
SjoerdMeijer retitled this revision from to Guard flag –fdenormal-fp-math with –fno-fast-math.
SjoerdMeijer updated this object.
SjoerdMeijer added reviewers: rengolin, jmolloy.
SjoerdMeijer added a subscriber: cfe-commits.
SjoerdMeijer updated this object.Oct 12 2016, 12:56 AM
SjoerdMeijer added a reviewer: hfinkel.
rengolin added inline comments.Oct 12 2016, 3:18 AM
test/Driver/denormal-fp-math.c
4

Please add all tests that the change is covering.

SjoerdMeijer updated this revision to Diff 74363.Oct 12 2016, 5:15 AM

Thanks for catching this: the logic and test have been updated.

rengolin accepted this revision.Oct 13 2016, 6:15 AM
rengolin edited edge metadata.

LGTM, thanks!

This revision is now accepted and ready to land.Oct 13 2016, 6:15 AM
SjoerdMeijer added a comment.Oct 13 2016, 6:27 AM

thanks again for reviewing.

Closed by commit rL284121: Guard flag –fdenormal-fp-math with –fno-fast-math. (authored by SjoerdMeijer). · Explain WhyOct 13 2016, 6:57 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
lib/
Driver/
11 lines
test/
Driver/
2 lines

Diff 74264

lib/Driver/Tools.cpp

  • This file is larger than 256 KB, so syntax highlighting is disabled by default.
Show First 20 Lines • Show All 4,384 Lines • ▼ Show 20 Lines if (!MathErrno && AssociativeMath && ReciprocalMath && !SignedZeros &&
CmdArgs.push_back("-menable-unsafe-fp-math"); CmdArgs.push_back("-menable-unsafe-fp-math");
if (!SignedZeros) if (!SignedZeros)
CmdArgs.push_back("-fno-signed-zeros"); CmdArgs.push_back("-fno-signed-zeros");
if (ReciprocalMath) if (ReciprocalMath)
CmdArgs.push_back("-freciprocal-math"); CmdArgs.push_back("-freciprocal-math");
if (!TrappingMath) if (!TrappingMath)
CmdArgs.push_back("-fno-trapping-math"); CmdArgs.push_back("-fno-trapping-math");
if (Args.hasArg(options::OPT_fdenormal_fp_math_EQ))
if (Arg *A = Args.getLastArg(options::OPT_ffast_math, FastMathAliasOption,
options::OPT_fno_fast_math,
options::OPT_fdenormal_fp_math_EQ))
if (A->getOption().getID() != options::OPT_fno_fast_math &&
A->getOption().getID() != options::OPT_fno_unsafe_math_optimizations)
Args.AddLastArg(CmdArgs, options::OPT_fdenormal_fp_math_EQ); Args.AddLastArg(CmdArgs, options::OPT_fdenormal_fp_math_EQ);
// Validate and pass through -fp-contract option. // Validate and pass through -fp-contract option.
if (Arg *A = Args.getLastArg(options::OPT_ffast_math, FastMathAliasOption, if (Arg *A = Args.getLastArg(options::OPT_ffast_math, FastMathAliasOption,
options::OPT_fno_fast_math, options::OPT_fno_fast_math,
options::OPT_ffp_contract)) { options::OPT_ffp_contract)) {
if (A->getOption().getID() == options::OPT_ffp_contract) { if (A->getOption().getID() == options::OPT_ffp_contract) {
StringRef Val = A->getValue(); StringRef Val = A->getValue();
if (Val == "fast" || Val == "on" || Val == "off") { if (Val == "fast" || Val == "on" || Val == "off") {
▲ Show 20 Lines • Show All 7,178 Lines • Show Last 20 Lines

test/Driver/denormal-fp-math.c

// RUN: %clang -### -target arm-unknown-linux-gnu -c %s -fdenormal-fp-math=ieee -v 2>&1 | FileCheck -check-prefix=CHECK-IEEE %s // RUN: %clang -### -target arm-unknown-linux-gnu -c %s -fdenormal-fp-math=ieee -v 2>&1 | FileCheck -check-prefix=CHECK-IEEE %s
// RUN: %clang -### -target arm-unknown-linux-gnu -c %s -fdenormal-fp-math=preserve-sign -v 2>&1 | FileCheck -check-prefix=CHECK-PS %s // RUN: %clang -### -target arm-unknown-linux-gnu -c %s -fdenormal-fp-math=preserve-sign -v 2>&1 | FileCheck -check-prefix=CHECK-PS %s
// RUN: %clang -### -target arm-unknown-linux-gnu -c %s -fdenormal-fp-math=positive-zero -v 2>&1 | FileCheck -check-prefix=CHECK-PZ %s // RUN: %clang -### -target arm-unknown-linux-gnu -c %s -fdenormal-fp-math=positive-zero -v 2>&1 | FileCheck -check-prefix=CHECK-PZ %s
// RUN: %clang -### -target arm-unknown-linux-gnu -c %s -fdenormal-fp-math=ieee -fno-fast-math -v 2>&1 | FileCheck -check-prefix=CHECK-NO-UNSAFE %s
rengolinUnsubmitted
Not Done
ReplyInline Actions

Please add all tests that the change is covering.

rengolin: Please add all tests that the change is covering.
// RUN: not %clang -target arm-unknown-linux-gnu -c %s -fdenormal-fp-math=foo -v 2>&1 | FileCheck -check-prefix=CHECK-INVALID %s // RUN: not %clang -target arm-unknown-linux-gnu -c %s -fdenormal-fp-math=foo -v 2>&1 | FileCheck -check-prefix=CHECK-INVALID %s
// CHECK-IEEE: "-fdenormal-fp-math=ieee" // CHECK-IEEE: "-fdenormal-fp-math=ieee"
// CHECK-PS: "-fdenormal-fp-math=preserve-sign" // CHECK-PS: "-fdenormal-fp-math=preserve-sign"
// CHECK-PZ: "-fdenormal-fp-math=positive-zero" // CHECK-PZ: "-fdenormal-fp-math=positive-zero"
// CHECK-NO-UNSAFE-NOT: "-fdenormal-fp-math=ieee"
// CHECK-INVALID: error: invalid value 'foo' in '-fdenormal-fp-math=foo' // CHECK-INVALID: error: invalid value 'foo' in '-fdenormal-fp-math=foo'