This is an archive of the discontinued LLVM Phabricator instance.

[AVR] Add the machine code disassembler
ClosedPublic

Authored by dylanmckay on Oct 7 2016, 7:36 PM.

Details

Reviewers
kparzysz
arsenm
Summary

This adds a super basic implementation of a machine code disassembler.

It doesn't support any operands with custom encoding.

Diff Detail

Event Timeline

dylanmckay updated this revision to Diff 74012.Oct 7 2016, 7:36 PM
dylanmckay retitled this revision from to [AVR] Add the machine code disassembler.
dylanmckay updated this object.
dylanmckay added reviewers: kparzysz, arsenm.
dylanmckay added subscribers: llvm-commits, japaric.
kparzysz added inline comments.Oct 21 2016, 5:10 PM
lib/Target/AVR/Disassembler/AVRDisassembler.cpp
89

No else after return.

104

No else after return.

138

Please break this line to fit in 80 columns. Here and line 150.

dylanmckay marked 3 inline comments as done.

Remove returns in else blocks, and keep everything within 80 columns.

kparzysz accepted this revision.Oct 22 2016, 6:23 AM
kparzysz edited edge metadata.
This revision is now accepted and ready to land.Oct 22 2016, 6:23 AM
dylanmckay closed this revision.Oct 27 2016, 12:08 AM

Committed in r284930