This is an archive of the discontinued LLVM Phabricator instance.

Differential D25352

[sanitizers] Set Darwin specific linker and compiler flags for sanitizer-common tests
ClosedPublic

Authored by zaks.anna on Oct 6 2016, 5:56 PM.

Details

Reviewers
kubamracek
beanz
Summary

Looks like we are missing these flags only in sanitizer-common, which results in linker warnings in some settings.

For example, we are not setting the minimal deployment target on the tests but are setting the minimal deployment target for the sanitizer library, which leads to the following warning on some bots: ld: warning: object file (sanitizer_posix_test.cc.i386.o) was built for newer OSX version (10.12) than being linked (10.11).

Diff Detail

Event Timeline

zaks.anna updated this revision to Diff 73870.Oct 6 2016, 5:56 PM
zaks.anna retitled this revision from to [sanitizers] Set Darwin specific linker and compiler flags for sanitizer-common tests.
zaks.anna updated this object.
zaks.anna added reviewers: kubamracek, beanz.
zaks.anna added a subscriber: llvm-commits.
Herald added a subscriber: mgorny. · View Herald TranscriptOct 6 2016, 5:56 PM
kubamracek accepted this revision.Oct 10 2016, 4:00 AM
kubamracek edited edge metadata.

LGTM.

This revision is now accepted and ready to land.Oct 10 2016, 4:00 AM
Eugene.Zelenko closed this revision.Nov 9 2016, 6:00 PM
Eugene.Zelenko added a subscriber: Eugene.Zelenko.

Committed in rL285255.

Revision Contents

PathSize
lib/
sanitizer_common/
tests/
5 lines

Diff 73870

lib/sanitizer_common/tests/CMakeLists.txt

Show First 20 Lines • Show All 72 Lines • ▼ Show 20 Lines
if(NOT MSVC) if(NOT MSVC)
list(APPEND SANITIZER_TEST_LINK_FLAGS_COMMON --driver-mode=g++) list(APPEND SANITIZER_TEST_LINK_FLAGS_COMMON --driver-mode=g++)
endif() endif()
if(ANDROID) if(ANDROID)
list(APPEND SANITIZER_TEST_LINK_FLAGS_COMMON -pie) list(APPEND SANITIZER_TEST_LINK_FLAGS_COMMON -pie)
endif() endif()
if(APPLE)
list(APPEND SANITIZER_TEST_CFLAGS_COMMON ${DARWIN_osx_CFLAGS})
list(APPEND SANITIZER_TEST_LINK_FLAGS_COMMON ${DARWIN_osx_LINKFLAGS})
endif()
# MSVC linker is allocating 1M for the stack by default, which is not # MSVC linker is allocating 1M for the stack by default, which is not
# enough for the unittests. Some unittests require more than 2M. # enough for the unittests. Some unittests require more than 2M.
# The default stack size for clang is 8M. # The default stack size for clang is 8M.
if(MSVC) if(MSVC)
list(APPEND SANITIZER_TEST_LINK_FLAGS_COMMON -Wl,/STACK:0xC00000) list(APPEND SANITIZER_TEST_LINK_FLAGS_COMMON -Wl,/STACK:0xC00000)
endif() endif()
set(SANITIZER_TEST_LINK_LIBS) set(SANITIZER_TEST_LINK_LIBS)
▲ Show 20 Lines • Show All 143 Lines • Show Last 20 Lines