This is an archive of the discontinued LLVM Phabricator instance.

Disable warnings in LLDBWrapPython.cpp when LLVM_ENABLE_WERROR is used
ClosedPublic

Authored by zturner on Oct 4 2016, 11:22 AM.

Details

Summary

We don't control the generated code here, so there often isn't anything we can do about these warnings. They'll still show when -Werror is off so they aren't completely silenced.

Diff Detail

Repository
rL LLVM

Event Timeline

zturner updated this revision to Diff 73510.Oct 4 2016, 11:22 AM
zturner retitled this revision from to Disable warnings in LLDBWrapPython.cpp when LLVM_ENABLE_WERROR is used.
zturner updated this object.
zturner added a reviewer: beanz.
zturner added a subscriber: lldb-commits.
labath added a subscriber: labath.Oct 4 2016, 11:29 AM

I wouldn't be opposed to completely disabling (a particular chosen set of warnings) for that file, regardless of whether we do -Werror or not.

You could use -Wno-error=<warning> instead.

You could use -Wno-error=<warning> instead.

Yes but it's a little bit annoying to track down every single one we get in this file with all the different compilers. Since we can't really control the generated code, there's not much we can do. Seems easier to just turn them off.

This revision was automatically updated to reflect the committed changes.