This is an archive of the discontinued LLVM Phabricator instance.

[lit] Throw in unimplemented method (NFC)
ClosedPublic

Authored by modocache on Oct 2 2016, 6:31 PM.

Details

Summary

lit's OneCommandFileTest class implements an abstract method that
raises if called. However, it raises by referencing an undefined
symbol. Instead, raise explicitly by throwing a NotImplementedError.
This is clearer, and appeases Python linters.

Event Timeline

modocache updated this revision to Diff 73231.Oct 2 2016, 6:31 PM
modocache retitled this revision from to [lit] Throw in unimplemented method (NFC).
modocache updated this object.
modocache added reviewers: ddunbar, echristo, beanz.
modocache added a subscriber: llvm-commits.
beanz accepted this revision.Oct 2 2016, 6:46 PM
beanz edited edge metadata.

LGTM!

This revision is now accepted and ready to land.Oct 2 2016, 6:46 PM
beanz added a comment.Oct 2 2016, 9:58 PM

Committed in rL283090. Thanks for the patch!

modocache closed this revision.Oct 3 2016, 4:51 PM

Thanks!