Page MenuHomePhabricator

[compiler-rt][asan] Disable a broken test on windows 64-bits
ClosedPublic

Authored by etienneb on Sep 28 2016, 12:15 PM.

Details

Summary

This test is broken on wndows 64-bit.

The interception library is not able to hook on the memchr functions.

Snippet of the function that is not hookable:

--- No source file -------------------------------------------------------------
000007FEFA1A18CD CC                   int         3  
000007FEFA1A18CE CC                   int         3  
000007FEFA1A18CF CC                   int         3  
--- f:\dd\vctools\crt\vcruntime\src\string\amd64_arm_arm64\memchr.c ------------
        while ( cnt && (*(unsigned char *)buf != (unsigned char)chr) ) {
000007FEFA1A18D0 4D 85 C0             test        r8,r8  
000007FEFA1A18D3 74 0D                je          memchr+12h (07FEFA1A18E2h)  
000007FEFA1A18D5 38 11                cmp         byte ptr [rcx],dl  
000007FEFA1A18D7 74 09                je          memchr+12h (07FEFA1A18E2h)  
                buf = (unsigned char *)buf + 1;
000007FEFA1A18D9 48 FF C1             inc         rcx  
                cnt--;
000007FEFA1A18DC 49 83 E8 01          sub         r8,1  
000007FEFA1A18E0 75 F3                jne         memchr+5h (07FEFA1A18D5h)  
        }

Diff Detail

Repository
rL LLVM

Event Timeline

etienneb updated this revision to Diff 72874.Sep 28 2016, 12:15 PM
etienneb retitled this revision from to [compiler-rt][asan] Disable a broken test on windows 64-bits.
etienneb updated this object.
etienneb added a reviewer: rnk.
etienneb added subscribers: chrisha, llvm-commits.
etienneb updated this object.Sep 28 2016, 12:16 PM
This revision was automatically updated to reflect the committed changes.
rnk edited edge metadata.Sep 30 2016, 8:00 AM

lgtm