This allows AVR to lower frames into assembly code.
Details
Diff Detail
- Build Status
Buildable 159 Build 159: arc lint + arc unit
Event Timeline
| lib/Target/AVR/AVRFrameLowering.cpp | ||
|---|---|---|
| 50 | Isn't this last condition backwards? Also, why use isUInt? | |
| 60 | Subtarget should be obtained from a MachineFunction, since it can be different every time. | |
| 149 | Check for MBBI being MBB.end(). Also, getDesc() is not necessary. | |
| 157 | Same note about Subtarget. | |
| 162 | These calls do not modify MBBI. | |
| 183 | That's just esthetics, but most of these parentheses are not necessary. | |
| 240 | Subtarget from MF. | |
| 280 | And here... | |
| 282 | Make it a range-based loop? | |
| 302 | "auto" is ok for iterators. | |
| 306 | Opcode is unsigned. | |
| 328 | ... | |
| 365 | ... | |
| 442 | Is this "if (x - y)"? if (x != y) would be clearer. | |
| 464 | Make it a range-based loop. | |
| 467 | Same here. | |
| 476 | And here. | |
| 516 | ... | |
| 530 | And here. | |
Code review from Krzysztof
- Converted a bunch of loops into range syntax
- Get AVRSubtarget from the current machine function
Thanks for the comprehensive review Krzysztof :)
| lib/Target/AVR/AVRFrameLowering.cpp | ||
|---|---|---|
| 50 |
Nice catch :)
I feel like it's more descriptive than Size > 63, which seems arbitrary - if we're checking if it can fit into 6 bits, it gives us a little more context on why it's there. | |
Isn't this last condition backwards? Also, why use isUInt?