Page MenuHomePhabricator

[ubsan] Turn on 'Has CXXABI' to enable support for -fsanitize=vptr on Darwin
ClosedPublic

Authored by vsk on Sep 27 2016, 3:06 PM.

Details

Summary

-fsanitize=vptr doesn't work on Darwin because we don't compile the necessary sanitizer handlers.

Fix the issue by exposing the definition of SANITIZER_MIN_OSX_VERSION to the logic which sets "use_cxxabi_default". Once this definition is available, we can verify that the user's version of macOS supports -fsanitize=vptr and then turn it on.

Diff Detail

Event Timeline

vsk updated this revision to Diff 72718.Sep 27 2016, 3:06 PM
vsk retitled this revision from to [ubsan] Turn on 'Has CXXABI' to enable support for -fsanitize=vptr on Darwin.
vsk updated this object.
vsk added reviewers: beanz, fjricci.
vsk added a subscriber: llvm-commits.
beanz accepted this revision.Oct 6 2016, 9:07 AM
beanz edited edge metadata.

LGTM!

This revision is now accepted and ready to land.Oct 6 2016, 9:07 AM
This revision was automatically updated to reflect the committed changes.