Page MenuHomePhabricator

[RFC] Inverse SQRT on ARM(do not merge)
Needs ReviewPublic

Authored by jojo on Sep 26 2016, 5:47 AM.

Details

Summary

Draft patch for this. As a preparation for the upcoming benchmarking,
It's ok just be able to emit.
And after that,we will give a final design.

Diff Detail

Event Timeline

jojo updated this revision to Diff 72471.Sep 26 2016, 5:47 AM
jojo retitled this revision from to [RFC] Inverse SQRT on ARM(do not merge).
jojo updated this object.
jojo added reviewers: jmolloy, evandro, rengolin.
jojo updated this revision to Diff 72989.Sep 30 2016, 12:01 AM

update diff

jmolloy edited edge metadata.Sep 30 2016, 12:12 AM

Hi Jojo,

As you're updating the diff, can you confirm that you don't want review at this point?

Cheers,

James

jojo added a comment.Sep 30 2016, 1:27 AM

Hi James,

Thanks very much!

I updated the diff as I did some tests basing on this diff. And I'm going to add comments
to the bug(bug 27107).
As I mentioned in the mail, I think this diff shouldn't be the final design for inverse sqrt
problem,but It would be ok just emitting rsqrt for upcoming benchmarking.
But even though, I'm not sure it's right. Especially I tried to support operations in f32 in
the diff.
If you could give me some advice, it would be very appreciated. : )

Regards,
Jojo

Hi Jojo,

As you're updating the diff, can you confirm that you don't want review at this point?

Cheers,

James

evandro edited edge metadata.Nov 29 2016, 1:20 PM

Do you intend to use the VRSQRTS to perform the series steps?

lib/Target/ARM/ARMTargetMachine.cpp
33

No need to capitalize each initial.