This is an archive of the discontinued LLVM Phabricator instance.

Differential D24907

NFC: separate file for fp denormal regression tests
ClosedPublic

Authored by SjoerdMeijer on Sep 26 2016, 4:05 AM.

Details

Reviewers
rengolin
jmolloy
hfinkel
olista01
Commits
rGa5d3fd47805d: This adds a separate file for the fp denormal regression tests. NFC.
rC283109: This adds a separate file for the fp denormal regression tests. NFC.
rL283109: This adds a separate file for the fp denormal regression tests. NFC.
Summary

For clarity, this moves checks for -fdenormal-fp-math values from fast-math.c to a new separate file.

Diff Detail

Repository
rL LLVM

Event Timeline

SjoerdMeijer updated this revision to Diff 72457.Sep 26 2016, 4:05 AM
SjoerdMeijer retitled this revision from to NFC: separate file for fp denormal regression tests.
SjoerdMeijer updated this object.
SjoerdMeijer added reviewers: rengolin, jmolloy, olista01.
SjoerdMeijer added a subscriber: cfe-commits.
SjoerdMeijer mentioned this in D24909: fix for not copying fp denormal and trapping options..Sep 26 2016, 5:18 AM
hfinkel accepted this revision.Oct 3 2016, 5:43 AM
hfinkel added a reviewer: hfinkel.
hfinkel added a subscriber: hfinkel.

This LGTM, although I find "fast-math.c" much easier to read than "denormalfpmode.c". How about naming it "denormal-fp-math.c" to match the option name?

This revision is now accepted and ready to land.Oct 3 2016, 5:43 AM
SjoerdMeijer added a comment.Oct 3 2016, 5:55 AM

Yes, excellent, I will rename it to denormal-fp-math.c and commit. Thanks for reviewing!

Closed by commit rL283109: This adds a separate file for the fp denormal regression tests. NFC. (authored by SjoerdMeijer). · Explain WhyOct 4 2016, 1:05 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
cfe/
trunk/
test/
Driver/
9 lines

Diff 73411

cfe/trunk/test/Driver/fast-math.c

Show First 20 Lines • Show All 228 Lines • ▼ Show 20 Lines
// RUN: %clang -### -ffast-math -fno-unsafe-math-optimizations -c %s 2>&1 \ // RUN: %clang -### -ffast-math -fno-unsafe-math-optimizations -c %s 2>&1 \
// RUN: | FileCheck --check-prefix=CHECK-NO-UNSAFE-MATH %s // RUN: | FileCheck --check-prefix=CHECK-NO-UNSAFE-MATH %s
// CHECK-NO-UNSAFE-MATH: "-cc1" // CHECK-NO-UNSAFE-MATH: "-cc1"
// CHECK-NO-UNSAFE-MATH-NOT: "-menable-unsafe-fp-math" // CHECK-NO-UNSAFE-MATH-NOT: "-menable-unsafe-fp-math"
// CHECK-NO-UNSAFE-MATH: "-o" // CHECK-NO-UNSAFE-MATH: "-o"
// //
// RUN: %clang -### -ftrapping-math -fno-trapping-math -c %s 2>&1 \ // RUN: %clang -### -ftrapping-math -fno-trapping-math -c %s 2>&1 \
// RUN: | FileCheck --check-prefix=CHECK-NO-TRAPPING-MATH %s // RUN: | FileCheck --check-prefix=CHECK-NO-TRAPPING-MATH %s
// RUN: %clang -### -fdenormal-fp-math=ieee -c %s 2>&1 \
// RUN: | FileCheck --check-prefix=CHECK-FP-DENORMAL-IEEE %s
// RUN: %clang -### -fdenormal-fp-math=preserve-sign -c %s 2>&1 \
// RUN: | FileCheck --check-prefix=CHECK-FP-DENORMAL-PS %s
// RUN: %clang -### -fdenormal-fp-math=positive-zero -c %s 2>&1 \
// RUN: | FileCheck --check-prefix=CHECK-FP-DENORMAL-PZ %s
// CHECK-NO-TRAPPING-MATH: "-fno-trapping-math" // CHECK-NO-TRAPPING-MATH: "-fno-trapping-math"
// CHECK-FP-DENORMAL-IEEE: "-fdenormal-fp-math=ieee"
// CHECK-FP-DENORMAL-PS: "-fdenormal-fp-math=preserve-sign"
// CHECK-FP-DENORMAL-PZ: "-fdenormal-fp-math=positive-zero"