This is an archive of the discontinued LLVM Phabricator instance.

AMDGPU/R600: Don't use REGISTER_{LOAD,STORE} ISD nodes
ClosedPublic

Authored by jvesely on Sep 19 2016, 2:21 PM.

Details

Summary

This helps eliminate few redundant MOVs from private AS loads/stores
I think we'd need to be smarter about MMO for truncating store/extending loads to eliminate all of them.

This also makes it much easier to switch to MEM_{RD,WR}_SCRATCH once mesa bits are done.

Diff Detail

Repository
rL LLVM

Event Timeline

jvesely updated this revision to Diff 71879.Sep 19 2016, 2:21 PM
jvesely retitled this revision from to AMDGPU/R600: Don't use REGISTER_{LOAD,STORE} ISD nodes.
jvesely updated this object.
jvesely set the repository for this revision to rL LLVM.
jvesely added a subscriber: llvm-commits.
tstellarAMD accepted this revision.Sep 21 2016, 10:08 AM
tstellarAMD edited edge metadata.

LGTM.

This revision is now accepted and ready to land.Sep 21 2016, 10:08 AM
jvesely planned changes to this revision.Sep 26 2016, 4:53 PM

Looks like I'll need to handle aliasing properly, before going ahead with this one.

jvesely updated this revision to Diff 82050.Dec 19 2016, 5:41 PM
jvesely edited edge metadata.
This revision is now accepted and ready to land.Dec 19 2016, 5:41 PM
jvesely requested a review of this revision.Dec 19 2016, 5:43 PM
jvesely edited edge metadata.

rebase and improve tests

arsenm accepted this revision.Jan 6 2017, 11:17 AM
arsenm added a reviewer: arsenm.

LGTM. Can the node definitions be deleted now?

lib/Target/AMDGPU/R600ISelLowering.cpp
1468 ↗(On Diff #82050)

The dump should be removed from here

This revision is now accepted and ready to land.Jan 6 2017, 11:17 AM
jvesely updated this revision to Diff 83407.Jan 6 2017, 12:59 PM
jvesely edited edge metadata.
jvesely marked an inline comment as done.Jan 6 2017, 1:05 PM

LGTM. Can the node definitions be deleted now?

yes. I kept them in case they might be useful in the future, but they are not used by anything atm.

This revision was automatically updated to reflect the committed changes.