This is an archive of the discontinued LLVM Phabricator instance.

AMDGPU: Remove scheduling info from si_mask_branch
ClosedPublic

Authored by arsenm on Sep 16 2016, 2:00 PM.

Details

Diff Detail

Event Timeline

arsenm updated this revision to Diff 71696.Sep 16 2016, 2:00 PM
arsenm retitled this revision from to AMDGPU: Remove scheduling info from si_mask_branch.
arsenm updated this object.
arsenm added a reviewer: tstellarAMD.
arsenm added a subscriber: llvm-commits.

Isn't hasNoSchedulingInfo = 0 the default setting?

Isn't hasNoSchedulingInfo = 0 the default setting?

Yes, but SchedRW is inherited from PseudoInstSI as Write32

Yes, the SchedRW part I agree with, but why the hasNoSchedulingInfo? Is there some additional interaction? FWIW, the change itself looks fine to me apart from that.

arsenm added a comment.Oct 6 2016, 9:38 AM

Yes, the SchedRW part I agree with, but why the hasNoSchedulingInfo? Is there some additional interaction? FWIW, the change itself looks fine to me apart from that.

I thought this was supposed to produce an error when the scheduling model is supposed to be complete. I'm not sure why this isn't actually erroring without it

arsenm updated this revision to Diff 73812.Oct 6 2016, 9:48 AM

Set bit in right direction

nhaehnle accepted this revision.Oct 6 2016, 11:01 AM
nhaehnle added a reviewer: nhaehnle.

LGTM

This revision is now accepted and ready to land.Oct 6 2016, 11:01 AM
arsenm closed this revision.Oct 6 2016, 11:21 AM

r283475