This is an archive of the discontinued LLVM Phabricator instance.

Differential D24678

[libc++] Fix inline attribute for non-MSVC Windows
ClosedPublic

Authored by smeenai on Sep 16 2016, 11:30 AM.

Details

Reviewers
mclow.lists
compnerd
EricWF
Commits
rG3b33938c05f1: [libc++] Fix inline attribute for non-MSVC Windows
rCXX281766: [libc++] Fix inline attribute for non-MSVC Windows
rL281766: [libc++] Fix inline attribute for non-MSVC Windows
Summary

gcc and clang in gcc compatibility mode do not accept __forceinline. Use
the gcc attribute for them instead.

Diff Detail

Event Timeline

smeenai updated this revision to Diff 71680.Sep 16 2016, 11:30 AM
smeenai retitled this revision from to [libc++] Fix inline attribute for non-MSVC Windows.
smeenai updated this object.
smeenai added reviewers: compnerd, EricWF, mclow.lists.
smeenai added a subscriber: cfe-commits.
EricWF accepted this revision.Sep 16 2016, 11:32 AM
EricWF edited edge metadata.
This revision is now accepted and ready to land.Sep 16 2016, 11:32 AM
Closed by commit rL281766: [libc++] Fix inline attribute for non-MSVC Windows (authored by smeenai). · Explain WhySep 16 2016, 12:21 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
include/
12 lines

Diff 71680

include/__config

Show First 20 Lines • Show All 554 Lines • ▼ Show 20 Lines
#define _LIBCPP_TYPE_VIS _LIBCPP_DLL_VIS #define _LIBCPP_TYPE_VIS _LIBCPP_DLL_VIS
#define _LIBCPP_FUNC_VIS _LIBCPP_DLL_VIS #define _LIBCPP_FUNC_VIS _LIBCPP_DLL_VIS
#define _LIBCPP_EXCEPTION_ABI _LIBCPP_DLL_VIS #define _LIBCPP_EXCEPTION_ABI _LIBCPP_DLL_VIS
#define _LIBCPP_EXTERN_TEMPLATE_TYPE_VIS _LIBCPP_DLL_VIS #define _LIBCPP_EXTERN_TEMPLATE_TYPE_VIS _LIBCPP_DLL_VIS
#define _LIBCPP_HIDDEN #define _LIBCPP_HIDDEN
#define _LIBCPP_TYPE_VIS_ONLY #define _LIBCPP_TYPE_VIS_ONLY
#define _LIBCPP_FUNC_VIS_ONLY #define _LIBCPP_FUNC_VIS_ONLY
#define _LIBCPP_ENUM_VIS #define _LIBCPP_ENUM_VIS
#if defined(_LIBCPP_MSVC)
#define _LIBCPP_INLINE_VISIBILITY __forceinline # define _LIBCPP_INLINE_VISIBILITY __forceinline
#define _LIBCPP_ALWAYS_INLINE __forceinline # define _LIBCPP_ALWAYS_INLINE __forceinline
#define _LIBCPP_EXTERN_TEMPLATE_INLINE_VISIBILITY __forceinline # define _LIBCPP_EXTERN_TEMPLATE_INLINE_VISIBILITY __forceinline
#else
# define _LIBCPP_INLINE_VISIBILITY __attribute__ ((__always_inline__))
# define _LIBCPP_ALWAYS_INLINE __attribute__ ((__always_inline__))
# define _LIBCPP_EXTERN_TEMPLATE_INLINE_VISIBILITY __attribute__ ((__always_inline__))
#endif
#endif // _WIN32 #endif // _WIN32
#ifndef _LIBCPP_HIDDEN #ifndef _LIBCPP_HIDDEN
#define _LIBCPP_HIDDEN __attribute__ ((__visibility__("hidden"))) #define _LIBCPP_HIDDEN __attribute__ ((__visibility__("hidden")))
#endif #endif
#ifndef _LIBCPP_FUNC_VIS #ifndef _LIBCPP_FUNC_VIS
#define _LIBCPP_FUNC_VIS __attribute__ ((__visibility__("default"))) #define _LIBCPP_FUNC_VIS __attribute__ ((__visibility__("default")))
▲ Show 20 Lines • Show All 355 Lines • Show Last 20 Lines