This is an archive of the discontinued LLVM Phabricator instance.

Install libLLVM if needed with LLVM_INSTALL_TOOLCHAIN_ONLY
ClosedPublic

Authored by sbc100 on Sep 16 2016, 10:33 AM.

Details

Summary

When LLVM_LINK_LLVM_DYLIB is set, the libLLVM shared
library needs to be installed in the toolchain. Without
this chanage LLVM_INSTALL_TOOLCHAIN_ONLY combined with
LLVM_LINK_LLVM_DYLIB results in a broken install.

This change will allow the workaround in the WASM
waterfall to be removed:
https://github.com/WebAssembly/waterfall/blob/master/src/build.py#L710

Diff Detail

Repository
rL LLVM

Event Timeline

sbc100 updated this revision to Diff 71673.Sep 16 2016, 10:33 AM
sbc100 retitled this revision from to Install libLLVM if needed with LLVM_INSTALL_TOOLCHAIN_ONLY.
sbc100 updated this object.

My first llvm change... please excuse my lack of knowledge.

dschuff accepted this revision.Sep 16 2016, 11:12 AM
dschuff edited edge metadata.
This revision is now accepted and ready to land.Sep 16 2016, 11:12 AM
beanz accepted this revision.Sep 16 2016, 11:56 AM
beanz edited edge metadata.

LGTM.

This revision was automatically updated to reflect the committed changes.