Please use GitHub pull requests for new patches. Phabricator shutdown timeline

CodeGen: Start using inrange annotations on vtable getelementptr.
ClosedPublic
Actions

Authored by pcc on Sep 9 2016, 2:42 PM.

Details

Reviewers

rjmccall
eugenis
rsmith

Commits

rG25a2b70cd042: CodeGen: Start using inrange annotations on vtable getelementptr.
rC289585: CodeGen: Start using inrange annotations on vtable getelementptr.
rL289585: CodeGen: Start using inrange annotations on vtable getelementptr.

Summary

This annotation allows the optimizer to split vtable groups, as permitted by
a change to the Itanium ABI that prevents compilers from adjusting virtual
table pointers between virtual tables.

Depends on D22296

Diff Detail

Repository: rL LLVM

Event Timeline

pcc updated this revision to Diff 70910.Sep 9 2016, 2:42 PM

pcc retitled this revision from to CodeGen: Start using inrange annotations on vtable getelementptr..

pcc updated this object.

pcc added reviewers: rsmith, eugenis.

pcc added a parent revision: D22296: CodeGen: New vtable group representation: struct of vtable arrays..

pcc added subscribers: cfe-commits, krasin.

pcc mentioned this in D22296: CodeGen: New vtable group representation: struct of vtable arrays..Sep 9 2016, 2:42 PM

Refresh

Ping

John, may I ask you to take a look?

I'm not sure I like this IR design, but this use of it seems fine. LGTM.

This revision is now accepted and ready to land.Dec 7 2016, 8:53 PM

Closed by commit rL289585: CodeGen: Start using inrange annotations on vtable getelementptr. (authored by pcc). · Explain WhyDec 13 2016, 1:01 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

cfe/

trunk/

lib/

CodeGen/

CGVTT.cpp

5 lines

ItaniumCXXABI.cpp

5 lines

test/

CodeGenCXX/

const-init-cxx11.cpp

6 lines

constructor-init.cpp

6 lines

copy-constructor-synthesis-2.cpp

2 lines

copy-constructor-synthesis.cpp

2 lines

microsoft-interface.cpp

4 lines

skip-vtable-pointer-initialization.cpp

14 lines

strict-vtable-pointers.cpp

4 lines

vtable-assume-load.cpp

14 lines

vtable-pointer-initialization.cpp

8 lines

vtt-layout.cpp

8 lines

Diff 81289

View Options

cfe/trunk/lib/CodeGen/CGVTT.cpp

View Options

cfe/trunk/lib/CodeGen/ItaniumCXXABI.cpp

View Options

cfe/trunk/test/CodeGenCXX/const-init-cxx11.cpp

View Options

cfe/trunk/test/CodeGenCXX/constructor-init.cpp

View Options

cfe/trunk/test/CodeGenCXX/copy-constructor-synthesis-2.cpp

View Options

cfe/trunk/test/CodeGenCXX/copy-constructor-synthesis.cpp

View Options

cfe/trunk/test/CodeGenCXX/microsoft-interface.cpp

View Options

cfe/trunk/test/CodeGenCXX/skip-vtable-pointer-initialization.cpp

View Options

cfe/trunk/test/CodeGenCXX/strict-vtable-pointers.cpp

View Options

cfe/trunk/test/CodeGenCXX/vtable-assume-load.cpp

View Options

cfe/trunk/test/CodeGenCXX/vtable-pointer-initialization.cpp

View Options

cfe/trunk/test/CodeGenCXX/vtt-layout.cpp

Please use GitHub pull requests for new patches. Phabricator shutdown timeline

CodeGen: Start using inrange annotations on vtable getelementptr.ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 81289

cfe/trunk/lib/CodeGen/CGVTT.cpp

cfe/trunk/lib/CodeGen/ItaniumCXXABI.cpp

cfe/trunk/test/CodeGenCXX/const-init-cxx11.cpp

cfe/trunk/test/CodeGenCXX/constructor-init.cpp

cfe/trunk/test/CodeGenCXX/copy-constructor-synthesis-2.cpp

cfe/trunk/test/CodeGenCXX/copy-constructor-synthesis.cpp

cfe/trunk/test/CodeGenCXX/microsoft-interface.cpp

cfe/trunk/test/CodeGenCXX/skip-vtable-pointer-initialization.cpp

cfe/trunk/test/CodeGenCXX/strict-vtable-pointers.cpp

cfe/trunk/test/CodeGenCXX/vtable-assume-load.cpp

cfe/trunk/test/CodeGenCXX/vtable-pointer-initialization.cpp

cfe/trunk/test/CodeGenCXX/vtt-layout.cpp

CodeGen: Start using inrange annotations on vtable getelementptr.
ClosedPublic
Actions

Revision Contents
Changeset List