This is an archive of the discontinued LLVM Phabricator instance.

[docs] Make WritingAnLLVMPass.rst up-to-date with current state of things
ClosedPublic

Authored by andreybokhanko on Sep 5 2016, 7:39 AM.

Details

Summary

This patch updates WritingAnLLVMPass.rst to make it in line with current state of things.

Specifically:

  • Makefile instructions replaced with CMake ones
  • Filenames replaced with correct ones
  • Example reformatted a bit to make it less confusing and more conforming to LLVM Coding Standards
  • opt tool output updated with what it actually prints nowdays
  • "gcse" (which doesn't exist anymore) replaced with "gvn" (which still does)

Yours,
Andrey

Diff Detail

Event Timeline

andreybokhanko retitled this revision from to [docs] Make WritingAnLLVMPass.rst up-to-date with current state of things.
andreybokhanko updated this object.
andreybokhanko added a subscriber: llvm-commits.

...pinging again!

Yours,
Andrey

Pinging again! (Third time's the charm?)

chandlerc accepted this revision.Sep 26 2016, 11:17 AM
chandlerc edited edge metadata.

Sorry for delays, but third time *is* the charm and this looks great! LGTM!

This revision is now accepted and ready to land.Sep 26 2016, 11:17 AM
This revision was automatically updated to reflect the committed changes.

Chandler, thank you for the review!

See -- I'm working on getting some patch currency... ;-)