Page MenuHomePhabricator

andreybokhanko (Andrey Bokhanko)
User

Projects

User does not belong to any projects.

User Details

User Since
Nov 18 2014, 5:51 AM (238 w, 5 d)

Recent Activity

Mar 13 2017

andreybokhanko added a comment to D30898: Add new -fverbose-asm that enables source interleaving.

Hi Roger,

Mar 13 2017, 2:49 PM

Oct 4 2016

andreybokhanko added a comment to D24814: Fix IntegerType::MAX_INT_BITS value.

Reid, thanks for looking at this!

Oct 4 2016, 5:53 AM

Sep 29 2016

andreybokhanko added a comment to D24814: Fix IntegerType::MAX_INT_BITS value.

Ping!

Sep 29 2016, 1:51 AM

Sep 27 2016

andreybokhanko added a comment to D24233: [docs] Make WritingAnLLVMPass.rst up-to-date with current state of things.

Chandler, thank you for the review!

Sep 27 2016, 5:16 AM

Sep 26 2016

andreybokhanko added a comment to D24233: [docs] Make WritingAnLLVMPass.rst up-to-date with current state of things.

Pinging again! (Third time's the charm?)

Sep 26 2016, 5:04 AM

Sep 21 2016

andreybokhanko retitled D24814: Fix IntegerType::MAX_INT_BITS value from to Fix IntegerType::MAX_INT_BITS value.
Sep 21 2016, 2:47 PM

Sep 19 2016

andreybokhanko added a comment to D24233: [docs] Make WritingAnLLVMPass.rst up-to-date with current state of things.

...pinging again!

Sep 19 2016, 7:10 AM

Sep 12 2016

andreybokhanko added a comment to D24233: [docs] Make WritingAnLLVMPass.rst up-to-date with current state of things.

Ping!

Sep 12 2016, 6:46 AM

Sep 5 2016

andreybokhanko retitled D24233: [docs] Make WritingAnLLVMPass.rst up-to-date with current state of things from to [docs] Make WritingAnLLVMPass.rst up-to-date with current state of things.
Sep 5 2016, 7:39 AM

Aug 17 2016

andreybokhanko updated the diff for D23404: Clarify suggestion to use "#if 0" ... "#endif" for large blocks of comments.

Chris, Chandler, thank you for the review!

Aug 17 2016, 7:57 AM

Aug 12 2016

andreybokhanko added a comment to D23404: Clarify suggestion to use "#if 0" ... "#endif" for large blocks of comments.

@lattner, thank you for the quick review -- I hoped / feared for more discussion! :-)

Aug 12 2016, 3:20 AM

Aug 11 2016

andreybokhanko retitled D23404: Clarify suggestion to use "#if 0" ... "#endif" for large blocks of comments from Remove suggestion to use if 0 ... undef for large blocks of comments to Remove suggestion to use "#if 0" ... "#endif" for large blocks of comments.
Aug 11 2016, 6:17 AM
andreybokhanko retitled D23404: Clarify suggestion to use "#if 0" ... "#endif" for large blocks of comments from to Remove suggestion to use if 0 ... undef for large blocks of comments.
Aug 11 2016, 5:44 AM
andreybokhanko added a comment to D21678: Fix For pr28288 - Error message in shift of vector values.

@uweigand Ulrich, any objections here? If not, I will commit this patch tomorrow (as the author, Vladimir, doesn't have commit access yet).

Aug 11 2016, 2:56 AM

Aug 5 2016

andreybokhanko added a comment to D23162: [docs] Adding target status definition to dev policy.

Hi Renato,

Aug 5 2016, 5:59 AM

Jul 29 2016

andreybokhanko accepted D22970: Ensure Ident_GNU_final is properly initialized in the Parser Initialize function.

I can commit this patch on Monday, when I will reach my work machine.

Jul 29 2016, 12:32 PM · Restricted Project

Jul 28 2016

andreybokhanko retitled D22913: Mention of proper support for "__unaligned" type qualifier in 3.9 clang release notes from to Mention of proper support for "__unaligned" type qualifier in 3.9 clang release notes.
Jul 28 2016, 4:53 AM

Jun 6 2016

andreybokhanko added a comment to D18035: [GCC] PR23529 Mangler part of attrbute abi_tag support.

The link was posted here: http://sourcerytools.com/pipermail/cxx-abi-dev/2016-June/002919.html - which is the mailing list where the C++ ABI specification is discussed.

Jun 6 2016, 3:55 PM
andreybokhanko added a comment to D18035: [GCC] PR23529 Mangler part of attrbute abi_tag support.

We just received the first draft of that specification yesterday.

Jun 6 2016, 1:44 PM
andreybokhanko updated subscribers of D18035: [GCC] PR23529 Mangler part of attrbute abi_tag support.
Jun 6 2016, 9:29 AM

May 26 2016

andreybokhanko added inline comments to D20437: [MSVC] Support of __unaligned qualifier for function types.
May 26 2016, 2:46 AM

May 20 2016

andreybokhanko added inline comments to D20437: [MSVC] Support of __unaligned qualifier for function types.
May 20 2016, 1:52 AM
andreybokhanko updated the diff for D20437: [MSVC] Support of __unaligned qualifier for function types.

Added a test for __unaligned arrays.

May 20 2016, 1:49 AM

May 19 2016

andreybokhanko retitled D20437: [MSVC] Support of __unaligned qualifier for function types from to [MSVC] Support of __unaligned qualifier for function types.
May 19 2016, 8:33 AM

May 11 2016

andreybokhanko added a comment to D20103: PR27132: Proper mangling for __unaligned qualifier (now with both PR27367 and PR27666 fixed).

Can we test pointers to data members? Is it possible to have __unaligned int *S::* or int *S::* __unaligned or even __unaligned int *S::* __unaligned ?

May 11 2016, 4:25 AM
andreybokhanko updated the diff for D20103: PR27132: Proper mangling for __unaligned qualifier (now with both PR27367 and PR27666 fixed).

Patch updated to address David's comments.

May 11 2016, 4:22 AM

May 10 2016

andreybokhanko retitled D20103: PR27132: Proper mangling for __unaligned qualifier (now with both PR27367 and PR27666 fixed) from to PR27132: Proper mangling for __unaligned qualifier (now with both PR27367 and PR27666 fixed).
May 10 2016, 8:22 AM

May 6 2016

andreybokhanko added a comment to D19654: PR27132: Proper mangling for __unaligned qualifier (now with PR27367 fixed).

David, thank you for the thorough review! -- it definitely made the patch stronger and me even more paranoid than the rest of Intel. :-)

May 6 2016, 4:56 AM

May 5 2016

andreybokhanko added a comment to D19654: PR27132: Proper mangling for __unaligned qualifier (now with PR27367 fixed).

David, just noticed that your first question doesn't have a redefinition. For this program:

May 5 2016, 3:33 AM
andreybokhanko added inline comments to D19654: PR27132: Proper mangling for __unaligned qualifier (now with PR27367 fixed).
May 5 2016, 3:25 AM

May 4 2016

andreybokhanko added inline comments to D19654: PR27132: Proper mangling for __unaligned qualifier (now with PR27367 fixed).
May 4 2016, 3:32 AM

Apr 29 2016

andreybokhanko added a comment to D19654: PR27132: Proper mangling for __unaligned qualifier (now with PR27367 fixed).

David, thank you for the review!

Apr 29 2016, 5:40 AM
andreybokhanko updated the diff for D19654: PR27132: Proper mangling for __unaligned qualifier (now with PR27367 fixed).

Fixed a bug uncovered by David Majnemer's review; added tests he asked for.

Apr 29 2016, 5:37 AM

Apr 28 2016

andreybokhanko retitled D19654: PR27132: Proper mangling for __unaligned qualifier (now with PR27367 fixed) from to PR27132: Proper mangling for __unaligned qualifier (now with PR27367 fixed).
Apr 28 2016, 5:09 AM

Apr 15 2016

andreybokhanko added a comment to D18596: [MSVC] PR27132: Proper mangling for __unaligned qualifier.

Reid, thank you!

Apr 15 2016, 1:09 AM

Apr 12 2016

andreybokhanko added inline comments to D18596: [MSVC] PR27132: Proper mangling for __unaligned qualifier.
Apr 12 2016, 7:06 PM
andreybokhanko updated the diff for D18596: [MSVC] PR27132: Proper mangling for __unaligned qualifier.
  1. Added more comprehensive overloading tests
  2. Added a warning (in C mode) / error (in C++ mode) on unaligned to non-unaligned type conversion
Apr 12 2016, 6:59 PM

Apr 8 2016

andreybokhanko updated the diff for D18596: [MSVC] PR27132: Proper mangling for __unaligned qualifier.

This patch implements "__unaligned" as a qualifier (as per David Majnemer's request).

Apr 8 2016, 6:56 AM

Apr 6 2016

andreybokhanko updated subscribers of D18171: [CUDA][OpenMP] Create generic offload action.
Apr 6 2016, 8:21 AM
andreybokhanko updated subscribers of D18172: [CUDA][OpenMP] Add a generic offload action builder.
Apr 6 2016, 8:21 AM
andreybokhanko updated subscribers of D18170: [CUDA][OpenMP] Create generic offload toolchains.
Apr 6 2016, 8:20 AM
andreybokhanko added a comment to D18596: [MSVC] PR27132: Proper mangling for __unaligned qualifier.

Do we want to do this for an ignored qualifier? I don't see any practical purpose.

It's not ignored for Windows on ARM.

Apr 6 2016, 2:01 AM

Apr 5 2016

andreybokhanko added a comment to D18596: [MSVC] PR27132: Proper mangling for __unaligned qualifier.

Regression is a bit of a question mark, to me depending on the diagnostic. I think warning the user "this has absolutely no effect" is a reasonable diagnostic for that situation -- the user wrote something, possibly expecting it to have an effect, and it turns out that it does absolutely nothing (including in the compiler that implements the language extension). If MSVC were to ever add semantic effect in those cases (diverging from what Clang implements), the diagnostic becomes even more important for Clang users. So I think it's fine to accept __unaligned for non-pointer types, but issue an "attribute ignored" warning diagnostic.

Apr 5 2016, 1:12 AM
andreybokhanko updated the diff for D18596: [MSVC] PR27132: Proper mangling for __unaligned qualifier.

Added Sema test, as per Aaron's and Reid's request.

Apr 5 2016, 12:55 AM

Mar 31 2016

andreybokhanko added a comment to D18596: [MSVC] PR27132: Proper mangling for __unaligned qualifier.

Aaron, Reid, David, thank you for the review!

Mar 31 2016, 8:04 AM
andreybokhanko updated the diff for D18596: [MSVC] PR27132: Proper mangling for __unaligned qualifier.

Resolved [some of] comments made by Aaron and Reid.

Mar 31 2016, 7:55 AM

Mar 30 2016

andreybokhanko retitled D18596: [MSVC] PR27132: Proper mangling for __unaligned qualifier from to [MSVC] PR27132: Proper mangling for __unaligned qualifier.
Mar 30 2016, 7:10 AM

Mar 9 2016

andreybokhanko abandoned D17444: [MSVC] Recognize "static_assert" keyword in C mode.

It seems the discussion (http://lists.llvm.org/pipermail/cfe-commits/Week-of-Mon-20160229/thread.html#151860) concluded that we don't want this fix to be committed until we see some compelling code that relies on "static_assert" availability in C language without <assert.h> being included.

Mar 9 2016, 7:47 AM · Restricted Project

Feb 26 2016

andreybokhanko awarded D17619: [MSVC Compat] Don't evaluate member base expressions w/o side effects a Like token.
Feb 26 2016, 4:16 AM
andreybokhanko added a comment to D17619: [MSVC Compat] Don't evaluate member base expressions w/o side effects.

@majnemer, this error in the header is now gone. Thank you! On to more errors! ;-)

Feb 26 2016, 4:16 AM

Feb 20 2016

andreybokhanko updated the diff for D17444: [MSVC] Recognize "static_assert" keyword in C mode.

Patch updated in response to Reid's proposal (to introduce KEYMSCOMPAT).

Feb 20 2016, 4:53 AM · Restricted Project

Feb 19 2016

andreybokhanko retitled D17444: [MSVC] Recognize "static_assert" keyword in C mode from to PR26672: [MSVC] Clang does not recognize "static_assert" keyword in C mode.
Feb 19 2016, 5:08 AM · Restricted Project

Feb 18 2016

andreybokhanko abandoned D17330: PR26648: "inline" shouldn't be recognized as a C keyword in MSVC 2013 compatibility mode.

@rnk, fair enough. OK, please consider this review request dropped.

Feb 18 2016, 2:35 AM

Feb 17 2016

andreybokhanko added a comment to D17330: PR26648: "inline" shouldn't be recognized as a C keyword in MSVC 2013 compatibility mode.

OK, so is initial patch a good one? ;-)

Feb 17 2016, 9:14 AM
andreybokhanko added a comment to D17330: PR26648: "inline" shouldn't be recognized as a C keyword in MSVC 2013 compatibility mode.

Why not just stick clang in C90 mode when targeting C if the -fms-compatibility-version is 18?

We have similar code for the C++ mode in https://github.com/llvm-mirror/clang/blob/master/lib/Driver/Tools.cpp#l5069

Feb 17 2016, 8:58 AM
andreybokhanko retitled D17330: PR26648: "inline" shouldn't be recognized as a C keyword in MSVC 2013 compatibility mode from to PR26648: "inline" shouldn't be recognized as a C keyword in MSVC 2013 compatibility mode.
Feb 17 2016, 2:44 AM
andreybokhanko added a comment to D17323: [OpenMP]Update to clang 3.8 ReleaseNotes.rst.

Along with Alexey's addition, this looks good.

Feb 17 2016, 2:40 AM

Feb 15 2016

andreybokhanko added a comment to D16846: PR26449: Fixes for bugs in __builtin_classify_type implementation.

John, thank you for all these tireless re-reviews -- very much appreciated!

Feb 15 2016, 2:44 AM

Feb 11 2016

tinti awarded D16851: Update of "GCC extensions not implemented yet" in Clang User's Manual a Like token.
Feb 11 2016, 3:28 AM
andreybokhanko added a comment to D16851: Update of "GCC extensions not implemented yet" in Clang User's Manual.

Assuming the features are implemented this seems fine. LGTM.

Feb 11 2016, 2:34 AM

Feb 10 2016

andreybokhanko updated the diff for D16846: PR26449: Fixes for bugs in __builtin_classify_type implementation.

John, thanks for the re-review! -- I did as you advised, and added *a lot* of switches. :-)

Feb 10 2016, 9:47 AM
andreybokhanko added a comment to D16851: Update of "GCC extensions not implemented yet" in Clang User's Manual.

Ping

Feb 10 2016, 3:36 AM
andreybokhanko updated subscribers of D9888: [OPENMP] Driver support for OpenMP offloading.
Feb 10 2016, 2:24 AM

Feb 4 2016

andreybokhanko updated the diff for D16846: PR26449: Fixes for bugs in __builtin_classify_type implementation.

John, thank you for the review!

Feb 4 2016, 6:26 AM

Feb 3 2016

andreybokhanko retitled D16851: Update of "GCC extensions not implemented yet" in Clang User's Manual from to Update of "GCC extensions not implemented yet" in Clang User's Manual.
Feb 3 2016, 5:45 AM
andreybokhanko updated D16846: PR26449: Fixes for bugs in __builtin_classify_type implementation.
Feb 3 2016, 3:49 AM
andreybokhanko retitled D16846: PR26449: Fixes for bugs in __builtin_classify_type implementation from to PR26449: Fixes for bugs in __builtin_classify_type implementation.
Feb 3 2016, 3:48 AM
andreybokhanko added a comment to D16626: [x86] Correct setting of WIntType for MCU target.

Ping!

Feb 3 2016, 1:55 AM

Jan 27 2016

andreybokhanko retitled D16626: [x86] Correct setting of WIntType for MCU target from to [x86] Correct setting of WIntType for MCU target.
Jan 27 2016, 5:54 AM

Jan 26 2016

andreybokhanko updated subscribers of D12834: add gcc abi_tag support.
Jan 26 2016, 6:04 AM
andreybokhanko added a reviewer for D12834: add gcc abi_tag support: aaron.ballman.
Jan 26 2016, 5:58 AM

Jan 22 2016

andreybokhanko added a comment to D16295: Change of UserLabelPrefix default value from "_" to "".

Rafael, thanks for the review!

Jan 22 2016, 7:45 AM

Jan 19 2016

andreybokhanko added a comment to D16295: Change of UserLabelPrefix default value from "_" to "".

@rafael, all these changes are driven by tests.

Jan 19 2016, 2:58 AM

Jan 18 2016

andreybokhanko retitled D16295: Change of UserLabelPrefix default value from "_" to "" from to Change of UserLabelPrefix default value from "_" to "".
Jan 18 2016, 6:41 AM

Jan 14 2016

andreybokhanko added a comment to D16138: Correct setting of UserLabelPrefix for MCU target.

@rafael, thank you!

Jan 14 2016, 2:47 AM
andreybokhanko added a comment to D15686: PR25910: clang allows two var definitions with the same mangled name.

@tra, @rnk, @rjmccall, thanks for the review!

Jan 14 2016, 2:46 AM

Jan 13 2016

andreybokhanko updated the diff for D16138: Correct setting of UserLabelPrefix for MCU target.

Patch updated to be in line with llvm trunk. Sorry for the noise.

Jan 13 2016, 3:00 AM
andreybokhanko retitled D16138: Correct setting of UserLabelPrefix for MCU target from to Correct setting of UserLabelPrefix for MCU target.
Jan 13 2016, 2:29 AM
andreybokhanko added a comment to D15686: PR25910: clang allows two var definitions with the same mangled name.
In D15686#325266, @rnk wrote:

I thought we already addressed this issue with @rjmccall and decided that, if the user intentionally declares extern "C" variables with an _Z prefix, then we know they are intentionally attempting to name some C++ global variable.

I'd rather just warn on all extern "C" declarations starting with _Z, and let users keep the pieces when things break.

Jan 13 2016, 2:10 AM

Jan 10 2016

andreybokhanko added a comment to D15686: PR25910: clang allows two var definitions with the same mangled name.
In D15686#319725, @tra wrote:

A better description of the problem would help. PR itself is somewhat short on details.

Jan 10 2016, 3:03 AM
andreybokhanko updated the diff for D15686: PR25910: clang allows two var definitions with the same mangled name.

Fixed tra's notes. All the fixes are local, logic of the patch is not changed.

Jan 10 2016, 3:01 AM

Jan 5 2016

andreybokhanko added inline comments to D15686: PR25910: clang allows two var definitions with the same mangled name.
Jan 5 2016, 4:41 AM
andreybokhanko updated the diff for D15686: PR25910: clang allows two var definitions with the same mangled name.

Fixed tra's note.

Jan 5 2016, 4:40 AM
andreybokhanko added inline comments to rL255766: [x86] Exclusion of incorrect include headers paths for MCU target.
Jan 5 2016, 3:39 AM

Jan 4 2016

andreybokhanko added a comment to D15686: PR25910: clang allows two var definitions with the same mangled name.

Ping!

Jan 4 2016, 5:15 AM

Dec 21 2015

andreybokhanko added inline comments to D15686: PR25910: clang allows two var definitions with the same mangled name.
Dec 21 2015, 5:14 AM
andreybokhanko retitled D15686: PR25910: clang allows two var definitions with the same mangled name from to PR25910: clang allows two var definitions with the same mangled name.
Dec 21 2015, 4:00 AM

Dec 16 2015

andreybokhanko added inline comments to rL254195: [x86] Exclusion of incorrect include headers paths for MCU target.
Dec 16 2015, 3:06 AM

Nov 24 2015

andreybokhanko retitled D14954: [x86] Exclusion of incorrect include headers paths for MCU target from to [x86] Exclusion of incorrect include headers paths for MCU target.
Nov 24 2015, 7:31 AM

Nov 3 2015

andreybokhanko retitled D14285: [x86] Additional small fix for MCU psABI support from to [x86] Additional small fix for MCU psABI support.
Nov 3 2015, 7:44 AM

Nov 2 2015

andreybokhanko added a comment to D14205: [x86] Front-end part of MCU psABI support.

Thanks for the review!

Nov 2 2015, 1:59 AM

Oct 30 2015

andreybokhanko retitled D14205: [x86] Front-end part of MCU psABI support from to [x86] Front-end part of MCU psABI support.
Oct 30 2015, 8:41 AM

Oct 16 2015

andreybokhanko updated subscribers of D13802: [OPENMP] Make -fopenmp to turn on OpenMP support by default..
Oct 16 2015, 8:47 AM
andreybokhanko updated subscribers of D13803: [OPENMP] Make -fopenmp to turn on OpenMP support by default, clang part.
Oct 16 2015, 8:47 AM

Sep 14 2015

andreybokhanko added a comment to D12402: PR24595: clang-cl fails to compile vswriter.h header from Windows SDK 8.1 in 32 bit mode.

OK -- I removed the check in Itanium ABI part, restored back the test and committed the patch.

Sep 14 2015, 2:33 PM

Sep 12 2015

andreybokhanko added inline comments to D12402: PR24595: clang-cl fails to compile vswriter.h header from Windows SDK 8.1 in 32 bit mode.
Sep 12 2015, 9:42 AM

Sep 10 2015

andreybokhanko added a comment to D12402: PR24595: clang-cl fails to compile vswriter.h header from Windows SDK 8.1 in 32 bit mode.

Reid, thank you for the review!

Sep 10 2015, 11:27 PM
andreybokhanko added a comment to D12402: PR24595: clang-cl fails to compile vswriter.h header from Windows SDK 8.1 in 32 bit mode.
Sep 10 2015, 12:32 PM
andreybokhanko updated the diff for D12402: PR24595: clang-cl fails to compile vswriter.h header from Windows SDK 8.1 in 32 bit mode.

Sorry for delayed reply. All your comments are fixed (it turned out that usage of DefaultCC instead of ToCC is the root of all evil; after I fixed this, all other problems went away).

Sep 10 2015, 12:31 PM

Sep 3 2015

andreybokhanko added inline comments to D12402: PR24595: clang-cl fails to compile vswriter.h header from Windows SDK 8.1 in 32 bit mode.
Sep 3 2015, 8:17 AM