Details
Details
Diff Detail
Diff Detail
- Repository
- rL LLVM
Event Timeline
Comment Actions
Hi Krzysztof,
Thanks for getting to the bottom of this!
LGTM with nitpicks:
- Use 'opt -instnamer' on the bitcode test cases to get rid of the [0-9]+ variables.
- One continue is now useless, see the inlined comment.
Cheers,
-Quentin
lib/CodeGen/LiveIntervalAnalysis.cpp | ||
---|---|---|
512 | We should get only operands that reads reg and is not a debug value. | |
lib/CodeGen/LiveRangeCalc.cpp | ||
173 | Add a comment saying that if we readsReg, but MO.isDef(), that means for a subrange that this is not a true use. | |
test/CodeGen/AMDGPU/scheduler-liveness-1.ll | ||
2 | Add more detail on what we are checking for. | |
test/CodeGen/AMDGPU/scheduler-liveness-2.ll | ||
2 | Edit. | |
test/CodeGen/AMDGPU/unigine-liveness-crash.ll | ||
3 | Ditto |
We should get only operands that reads reg and is not a debug value.
I.e., turn that into an assert or leave it out.