Page MenuHomePhabricator

Minimize linux-specific variant of scariness_score_test.cc
ClosedPublic

Authored by filcab on Sep 1 2016, 9:00 AM.

Details

Summary

After moving most of the tests to a cross-platform test in r280361, I'm
removing the duplicate tests from the Linux version.

The only test-case that isn't being checked in the cross-OS version is
the abort() call.

Filed as a phabricator patch so someone can run it on Linux before I commit, to
make sure everything is ok.

Diff Detail

Event Timeline

filcab updated this revision to Diff 70020.Sep 1 2016, 9:00 AM
filcab retitled this revision from to Minimize linux-specific variant of scariness_score_test.cc.
filcab updated this object.
filcab added reviewers: kcc, eugenis, vitalybuka.
filcab added a subscriber: llvm-commits.
vitalybuka requested changes to this revision.Sep 1 2016, 12:07 PM
vitalybuka edited edge metadata.

Please revert 280361 and combine with this one.

This revision now requires changes to proceed.Sep 1 2016, 12:07 PM
filcab updated this revision to Diff 70052.Sep 1 2016, 12:37 PM
filcab edited edge metadata.

Update after reverting r280361.

vitalybuka accepted this revision.Sep 1 2016, 12:54 PM
vitalybuka edited edge metadata.

Please update description with [asan]
LGTM

This revision is now accepted and ready to land.Sep 1 2016, 12:54 PM
filcab closed this revision.Sep 5 2016, 8:31 AM

Landed as r280469