This is an archive of the discontinued LLVM Phabricator instance.

Add testcases for PR30188
AbandonedPublic

Authored by sebpop on Aug 31 2016, 12:09 PM.

Details

Summary

Add testcases to clang test/ to make sure that the combined middle-end
optimizations do not regress on optimizing the number of loads in the loops.

Diff Detail

Event Timeline

sebpop updated this revision to Diff 69890.Aug 31 2016, 12:09 PM
sebpop retitled this revision from to Add testcases for PR30188.
sebpop updated this object.
sebpop added subscribers: llvm-commits, cfe-commits.
davidxl added inline comments.Aug 31 2016, 1:50 PM
clang/test/CodeGen/pr30188.c
3

Can you just do

... | grep load | count 3

7

Also check there is no store

clang/test/CodeGenCXX/pr30188.cpp
5

check no store as well?

rsmith requested changes to this revision.Aug 31 2016, 2:34 PM
rsmith added a reviewer: rsmith.
rsmith added a subscriber: rsmith.

This belongs in LLVM's test suite, not Clang's.

This revision now requires changes to proceed.Aug 31 2016, 2:34 PM
sebpop abandoned this revision.Sep 1 2016, 11:40 AM

Agreed, this is a test for llvm/opt.
I will submit another patch.