This is an archive of the discontinued LLVM Phabricator instance.

Split ScarinessScore between its "storage" (POD), and an initializing object.
ClosedPublic

Authored by filcab on Aug 30 2016, 8:25 AM.

Details

Summary

This is needed so we can use it for D23672 on VS2013, since this VS
version doesn't support unrestricted unions, and doesn't allow us to
uses an object without a trivial default constructor inside a union.

Diff Detail

Event Timeline

filcab updated this revision to Diff 69690.Aug 30 2016, 8:25 AM
filcab retitled this revision from to Split ScarinessScore between its "storage" (POD), and an initializing object..
filcab updated this object.
filcab added reviewers: kcc, samsonov.
filcab added a subscriber: llvm-commits.
filcab updated this revision to Diff 69691.Aug 30 2016, 8:28 AM

Updated to account for D24029.
Kostya: I know you've accepted the revision, but since this is a non-trivial change, I'm updating it to show why D24029 would help.

filcab updated this revision to Diff 69696.Aug 30 2016, 8:32 AM

Merged two commits by mistake.

kcc accepted this revision.Aug 30 2016, 10:04 AM
kcc edited edge metadata.

LGTM

This revision is now accepted and ready to land.Aug 30 2016, 10:04 AM